Use swap_tensors path in nn.Module.to for FakeTensor #152539

mikaylagawarecki · 2025-04-30T17:22:17Z

Fixes #148977

Stack from ghstack (oldest at bottom):

-> Use swap_tensors path in nn.Module.to for FakeTensor #152539

Differential Revision: D76458023

…e __torch_dispatch__ [ghstack-poisoned]

pytorch-bot · 2025-04-30T17:22:21Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152539

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit dc2530a with merge base 3040ca6 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh) (trunk failure)
MISSING REGRESSION TEST
pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge) (gh) (trunk failure)
exir/backend/test/test_to_backend_multi_method.py::TestToBackendMultiMethod::test_multi_method_end_to_end

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…e __torch_dispatch__ ghstack-source-id: 3259d7b Pull Request resolved: #152539

…hat override __torch_dispatch__" Fixes #148977 [ghstack-poisoned]

…e __torch_dispatch__ ghstack-source-id: 169b711 Pull Request resolved: #152539

albanD

SGTM !

…hat override __torch_dispatch__" Fixes #148977 [ghstack-poisoned]

…e __torch_dispatch__ ghstack-source-id: 6eedb0b Pull Request resolved: #152539

mikaylagawarecki · 2025-05-01T15:20:04Z

@pytorchbot merge

pytorchmergebot · 2025-05-01T15:22:11Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-05-01T15:54:06Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 1, 3, lf.ephemeral.linux.arm64.m7g.4xlarge)

Details for Dev Infra team

Raised by workflow job

mikaylagawarecki · 2025-05-01T16:27:23Z

@pytorchbot merge

pytorchmergebot · 2025-05-01T16:29:21Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

wdvr · 2025-05-02T06:40:52Z

@pytorchmergebot revert -m "failing internal tests - discussed with author" -c ghfirst

pytorchmergebot · 2025-05-02T06:43:26Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

… override __torch_dispatch__ (#152539)" This reverts commit 0373436. Reverted #152539 on behalf of https://github.com/wdvr due to failing internal tests - discussed with author ([comment](#152539 (comment)))

pytorchmergebot · 2025-05-02T06:43:39Z

@mikaylagawarecki your PR has been successfully reverted.

…hat override __torch_dispatch__" Fixes #148977 [ghstack-poisoned]

…e __torch_dispatch__ ghstack-source-id: f0c27ad Pull Request resolved: #152539

mikaylagawarecki · 2025-06-11T20:34:07Z

@mikaylagawarecki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…hat override __torch_dispatch__" Fixes #148977 Differential Revision: [D76458023](https://our.internmc.facebook.com/intern/diff/D76458023) [ghstack-poisoned]

…e __torch_dispatch__ ghstack-source-id: 393c4f5 Pull Request resolved: #152539

mikaylagawarecki · 2025-06-12T15:29:13Z

@mikaylagawarecki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

albanD

PT change looks good!

mikaylagawarecki · 2025-06-12T22:00:53Z

@pytorchbot merge

pytorchmergebot · 2025-06-12T22:02:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Use swap_tensors path in nn.Module.to for all subclasses that overrid…

3a49d6d

…e __torch_dispatch__ [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Apr 30, 2025

Use swap_tensors path in nn.Module.to for all subclasses that overrid…

72e91c1

…e __torch_dispatch__ ghstack-source-id: 3259d7b Pull Request resolved: #152539

mikaylagawarecki added the release notes: nn release notes category label Apr 30, 2025

Update on "Use swap_tensors path in nn.Module.to for all subclasses t…

36778f7

…hat override __torch_dispatch__" Fixes #148977 [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Apr 30, 2025

Use swap_tensors path in nn.Module.to for all subclasses that overrid…

41f80c8

…e __torch_dispatch__ ghstack-source-id: 169b711 Pull Request resolved: #152539

mikaylagawarecki marked this pull request as ready for review April 30, 2025 21:24

mikaylagawarecki requested review from albanD and jbschlosser as code owners April 30, 2025 21:24

albanD approved these changes Apr 30, 2025

View reviewed changes

Update on "Use swap_tensors path in nn.Module.to for all subclasses t…

8556150

…hat override __torch_dispatch__" Fixes #148977 [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Apr 30, 2025

Use swap_tensors path in nn.Module.to for all subclasses that overrid…

1cb9fd1

…e __torch_dispatch__ ghstack-source-id: 6eedb0b Pull Request resolved: #152539

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 1, 2025

pytorchmergebot added the merging label May 1, 2025

pytorchmergebot removed the merging label May 1, 2025

pytorchmergebot added the merging label May 1, 2025

pytorchmergebot added the Merged label May 1, 2025

pytorchmergebot closed this in 0373436 May 1, 2025

pytorchmergebot removed the merging label May 1, 2025

pytorchmergebot added the Reverted label May 2, 2025

pytorchmergebot added the ci-no-td Do not run TD on this PR label May 2, 2025

pytorchmergebot reopened this May 2, 2025

mikaylagawarecki mentioned this pull request May 15, 2025

Update serialization docs #153631

Closed

Update on "Use swap_tensors path in nn.Module.to for all subclasses t…

8218efe

…hat override __torch_dispatch__" Fixes #148977 [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Jun 11, 2025

Use swap_tensors path in nn.Module.to for all subclasses that overrid…

de0247b

…e __torch_dispatch__ ghstack-source-id: f0c27ad Pull Request resolved: #152539

Update on "Use swap_tensors path in nn.Module.to for all subclasses t…

dc2530a

…hat override __torch_dispatch__" Fixes #148977 Differential Revision: [D76458023](https://our.internmc.facebook.com/intern/diff/D76458023) [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Jun 12, 2025

Use swap_tensors path in nn.Module.to for all subclasses that overrid…

13c6304

…e __torch_dispatch__ ghstack-source-id: 393c4f5 Pull Request resolved: #152539

mikaylagawarecki changed the title ~~Use swap_tensors path in nn.Module.to for all subclasses that override __torch_dispatch__~~ Use swap_tensors path in nn.Module.to for FakeTensor Jun 12, 2025

albanD approved these changes Jun 12, 2025

View reviewed changes

pytorchmergebot added the merging label Jun 12, 2025

pytorchmergebot closed this in 38bfd46 Jun 12, 2025

pytorchmergebot removed the merging label Jun 12, 2025

github-actions bot deleted the gh/mikaylagawarecki/311/head branch July 14, 2025 02:22

mikaylagawarecki mentioned this pull request Aug 22, 2025

Use overwrite module params path for FakeTensor in nn.Module._apply #161291

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use swap_tensors path in nn.Module.to for FakeTensor #152539

Use swap_tensors path in nn.Module.to for FakeTensor #152539

Uh oh!

mikaylagawarecki commented Apr 30, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

albanD left a comment

Uh oh!

mikaylagawarecki commented May 1, 2025

Uh oh!

pytorchmergebot commented May 1, 2025

Uh oh!

pytorchmergebot commented May 1, 2025

Uh oh!

mikaylagawarecki commented May 1, 2025

Uh oh!

pytorchmergebot commented May 1, 2025

Uh oh!

wdvr commented May 2, 2025

Uh oh!

pytorchmergebot commented May 2, 2025

Uh oh!

pytorchmergebot commented May 2, 2025

Uh oh!

mikaylagawarecki commented Jun 11, 2025

Uh oh!

mikaylagawarecki commented Jun 12, 2025

Uh oh!

albanD left a comment

Uh oh!

mikaylagawarecki commented Jun 12, 2025

Uh oh!

pytorchmergebot commented Jun 12, 2025

Uh oh!

Uh oh!

Use swap_tensors path in nn.Module.to for FakeTensor #152539

Use swap_tensors path in nn.Module.to for FakeTensor #152539

Uh oh!

Conversation

mikaylagawarecki commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152539

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

mikaylagawarecki commented May 1, 2025

Uh oh!

pytorchmergebot commented May 1, 2025

Merge started

Uh oh!

pytorchmergebot commented May 1, 2025

Merge failed

Uh oh!

mikaylagawarecki commented May 1, 2025

Uh oh!

pytorchmergebot commented May 1, 2025

Merge started

Uh oh!

wdvr commented May 2, 2025

Uh oh!

pytorchmergebot commented May 2, 2025

Uh oh!

pytorchmergebot commented May 2, 2025

Uh oh!

mikaylagawarecki commented Jun 11, 2025

Uh oh!

mikaylagawarecki commented Jun 12, 2025

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

mikaylagawarecki commented Jun 12, 2025

Uh oh!

pytorchmergebot commented Jun 12, 2025

Merge started

Uh oh!

Uh oh!

mikaylagawarecki commented Apr 30, 2025 •

edited

Loading

pytorch-bot bot commented Apr 30, 2025 •

edited

Loading