Handle aten.to at submodule boundaries #153972
Conversation
tugsbayasgalan
requested review from
avikchaudhuri,
zhxchen17,
ydwu4 and
angelayi
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153972
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 76cfb7c with merge base bee93f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
d9fdfee to
8316569
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
8316569 to
5456ca0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
changed the title
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
5456ca0 to
c01f843
Compare
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
c01f843 to
3bed9ae
Compare
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
3bed9ae to
5739e31
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
5739e31 to
1be3847
Compare
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
1be3847 to
b39b791
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
6de385e to
fd44d35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
fd44d35 to
54e29b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
54e29b1 to
679983b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
Summary: Pull Request resolved: pytorch#153972 #buildall Test Plan: CI Reviewed By: SherlockNoMad, avikchaudhuri Differential Revision: D74582970
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
679983b to
8d14c9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
8d14c9b to
3a528e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
3a528e8 to
0358a20
Compare
Summary: Pull Request resolved: pytorch#153972 #buildall Test Plan: CI Reviewed By: SherlockNoMad, avikchaudhuri Differential Revision: D74582970
|
This pull request was exported from Phabricator. Differential Revision: D74582970 |
tugsbayasgalan
force-pushed
the
export-D74582970
branch
from
0358a20 to
76cfb7c
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: #buildall
Test Plan: CI
Differential Revision: D74582970
When we decompose to inference IR, aten.to can sometimes disappear. As a result, export module call graph tree will start containing dead nodes because previous provenance tracking is insufficient. This PR fixes that. The caveat is that this won't work in general for tensor subclass inputs to submodule that user wants to preserve signature because we always desugar the tensor subclass into constituent tensors in inference IR making it impossible to preserve the original calling convention.
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv