Skip to content

[OpenReg][1/N] Migrate cpp_extensions_open_device_registration to OpenReg #154019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[OpenReg][1/N] Migrate cpp_extensions_open_device_registration to OpenReg #154019

wants to merge 10 commits into from

Conversation

FFFrog
Copy link
Collaborator

@FFFrog FFFrog commented May 21, 2025 •
edited
Loading

@FFFrog
Update
540f662 
[ghstack-poisoned]
@FFFrog FFFrog mentioned this pull request May 21, 2025
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 21, 2025
@FFFrog FFFrog mentioned this pull request May 21, 2025
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154019

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit d5f93f9 with merge base 56b03df (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@FFFrog FFFrog requested a review from albanD May 21, 2025 08:11
@FFFrog
Update
0762f33 
[ghstack-poisoned]
FFFrog added a commit that referenced this pull request May 21, 2025
@FFFrog
[OpenReg][1/N] Migrate cpp_extensions_open_device_registration to Ope…
6080dbc 
…nReg

As the title stated.

ghstack-source-id: f881eb0
Pull Request resolved: #154019
albanD
albanD approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@FFFrog
Update
702c749 
[ghstack-poisoned]
@FFFrog
Update
315ca29 
[ghstack-poisoned]
@FFFrog FFFrog mentioned this pull request May 22, 2025
Closed
@FFFrog
Update
a1cea9e 
[ghstack-poisoned]
@FFFrog FFFrog mentioned this pull request May 23, 2025
Closed
@FFFrog
Update
2689a8a 
[ghstack-poisoned]
This was referenced Jun 4, 2025
Closed
Closed
Closed
FFFrog added 3 commits June 5, 2025 14:48
@FFFrog
Update
5d50ac9 
[ghstack-poisoned]
@FFFrog
Update
009b11b 
[ghstack-poisoned]
@FFFrog
Update
f642d39 
[ghstack-poisoned]
@FFFrog
Copy link
Collaborator Author

FFFrog commented Jun 13, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 13, 2025
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #155191

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #155101

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154106

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154181

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #155191

@FFFrog
Update
d5f93f9 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #155191

2 similar comments
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #155191

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #155191

pytorchmergebot pushed a commit that referenced this pull request Jun 14, 2025
@FFFrog @pytorchmergebot
[OpenReg][2/N] Migrate cpp_extensions_open_device_registration to Ope…
7e5f29b 
…nReg (#154106)

As the title stated.
Pull Request resolved: #154106
Approved by: https://github.com/nareshrajkumar866, https://github.com/albanD
ghstack dependencies: #153947, #154018, #154019
pytorchmergebot pushed a commit that referenced this pull request Jun 14, 2025
@FFFrog @pytorchmergebot
[OpenReg][3/N] Migrate cpp_extensions_open_device_registration to Ope…
1e7989c 
…nReg (#154181)

As the title stated.

**Involved testcases**:
- test_open_device_quantized
- test_open_device_random
- test_open_device_tensor
- test_open_device_packed_sequence
- test_open_device_storage
Pull Request resolved: #154181
Approved by: https://github.com/albanD
ghstack dependencies: #153947, #154018, #154019, #154106
pytorchmergebot pushed a commit that referenced this pull request Jun 14, 2025
@FFFrog @pytorchmergebot
[OpenReg][4/N] Migrate cpp_extensions_open_device_registration to Ope…
e4fd0bf 
…nReg (#155101)

As the title stated.

**Involved testcases**:
- test_open_device_storage_pin_memory
- test_open_device_serialization
Pull Request resolved: #155101
Approved by: https://github.com/albanD
ghstack dependencies: #153947, #154018, #154019, #154106, #154181
pytorchmergebot pushed a commit that referenced this pull request Jun 14, 2025
@FFFrog @pytorchmergebot
[OpenReg][5/N] add set_.source_Storage for openreg (#155191)
187828d 
**Changes**:
- add set_.source_Storage for openreg to support torch.load & torch.serialization
- uncomment some related tests in the test_openreg.py
Pull Request resolved: #155191
Approved by: https://github.com/albanD
ghstack dependencies: #153947, #154018, #154019, #154106, #154181, #155101
@github-actions github-actions bot deleted the gh/fffrog/96/head branch July 15, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FFFrog @pytorchmergebot @albanD @pytorchbot