Skip to content

Conversation

rec
Copy link
Collaborator

@rec rec commented May 21, 2025

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 21, 2025
@rec rec added module: typing Related to mypy type annotations module: lint Issues related to our Python/C++ lint rules (run by Travis) labels May 21, 2025
[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154059

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8c11145 with merge base 9a8c42f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

rec added a commit that referenced this pull request May 21, 2025
ghstack-source-id: 0841f02
Pull Request resolved: #154059
[ghstack-poisoned]
rec added a commit that referenced this pull request May 22, 2025
ghstack-source-id: e25588f
Pull Request resolved: #154059
[ghstack-poisoned]
rec added a commit to rec/pytorch that referenced this pull request May 22, 2025
ghstack-source-id: 3108626
Pull Request resolved: pytorch#154059
rec added a commit to rec/pytorch that referenced this pull request May 22, 2025
ghstack-source-id: 3108626
Pull Request resolved: pytorch#154059
[ghstack-poisoned]
@rec rec mentioned this pull request May 22, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
rec added a commit that referenced this pull request May 23, 2025
ghstack-source-id: 4903af9
Pull Request resolved: #154059
@ezyang
Copy link
Contributor

ezyang commented May 24, 2025

And this one we can't merge until there's a worked out commitment to this typechecker "for real"

@rec
Copy link
Collaborator Author

rec commented May 26, 2025

@ezyang : Oh, absolutely. I was wanting to show the nice pyrefly people how their tool would look if it were part of the lintrunner CI.

I realized also that there is a fundamental incompatibility between lintrunner, which checks only the files changed in the most recent commit, and pyrefly, which expects to get the whole codebase (and completes in a bit over 4 seconds).

@ezyang
Copy link
Contributor

ezyang commented May 26, 2025

That's fine, lintrunner does that as a perf optimization, if full codebase is fast then it's not needsd

@rec
Copy link
Collaborator Author

rec commented Jul 4, 2025

I'm closing this but we can always reopen it at any time. 🙂

@rec rec closed this Jul 4, 2025
@github-actions github-actions bot deleted the gh/rec/150/head branch August 4, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: lint Issues related to our Python/C++ lint rules (run by Travis) module: typing Related to mypy type annotations open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants