Skip to content

[hop schema] add schema.tree_spec to support pytree inputs #154191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

[hop schema] add schema.tree_spec to support pytree inputs #154191

wants to merge 17 commits into from

Conversation

ydwu4
Copy link
Contributor

@ydwu4 ydwu4 commented May 23, 2025 •
edited
Loading

@ydwu4 ydwu4 requested a review from zou3519 as a code owner May 23, 2025 06:54
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154191

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit a4273c4 with merge base 08d15d3 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced May 22, 2025
Closed
Closed
Closed
Closed
Closed
@ydwu4 ydwu4 added the topic: not user facing topic category label May 29, 2025
@ydwu4 ydwu4 mentioned this pull request May 29, 2025
Closed
zou3519
zou3519 reviewed Jun 2, 2025
View reviewed changes
zou3519
zou3519 reviewed Jun 2, 2025
View reviewed changes
@ydwu4 ydwu4 mentioned this pull request Jun 5, 2025
Closed
@ydwu4 ydwu4 requested a review from zou3519 June 6, 2025 21:58
@ydwu4 ydwu4 added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2025
zou3519
zou3519 reviewed Jun 9, 2025
View reviewed changes
torch/_higher_order_ops/base_hop.py Outdated
for out in output:
schema_gen.add_output(out)

# schema_gen.add_schema_tree_spec(subgraph, *operands, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we no longer need this anymore. If no schema_tree_spec is added, we'll just treat it as None.

zou3519
zou3519 approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test?

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154192

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154192

This was referenced Jun 10, 2025
Closed
Closed
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154192

@ydwu4 ydwu4 mentioned this pull request Jun 11, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154192

pytorchmergebot pushed a commit that referenced this pull request Jun 11, 2025
@ydwu4 @pytorchmergebot
[refactor] make do_auto_functionalize_v2 take HopInstance (#154192)
4a954fc 
Pull Request resolved: #154192
Approved by: https://github.com/zou3519
ghstack dependencies: #155261, #154072, #154191
@github-actions github-actions bot deleted the gh/ydwu4/251/head branch July 13, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydwu4 @pytorchmergebot @zou3519