Skip to content

Conversation

Copy link

pytorch-bot bot commented May 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154688

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 7ea3ff9 with merge base ea37f72 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos added the ciflow/trunk Trigger trunk jobs on your pull request label May 29, 2025
@mlazos mlazos force-pushed the mlazos/fuse-window branch from 2ec8e50 to 9af5306 Compare May 30, 2025 17:33
@facebook-github-bot
Copy link
Contributor

@mlazos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mlazos mlazos force-pushed the mlazos/fuse-window branch 2 times, most recently from 8932b81 to 97fc6e0 Compare June 2, 2025 05:05
@mlazos mlazos changed the title [Inductor] Limit fusions to a node distance of 64 [Inductor] Limit fusions to a node distance of 128 Jun 2, 2025
@mlazos mlazos force-pushed the mlazos/fuse-window branch 2 times, most recently from e786f6d to 654bce0 Compare June 2, 2025 05:37
@mlazos mlazos changed the title [Inductor] Limit fusions to a node distance of 128 [Inductor] Limit fusions to a node distance of 64 Jun 2, 2025
@facebook-github-bot
Copy link
Contributor

@mlazos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mlazos mlazos force-pushed the mlazos/fuse-window branch 2 times, most recently from aa07d1e to fa19ad9 Compare June 3, 2025 18:30
@mlazos mlazos closed this Jun 5, 2025
@mlazos mlazos force-pushed the mlazos/fuse-window branch from fa19ad9 to 1e20745 Compare June 5, 2025 08:00
@mlazos mlazos reopened this Jun 5, 2025
@mlazos mlazos force-pushed the mlazos/fuse-window branch from 9030f39 to 8576f00 Compare June 7, 2025 01:26
@mlazos mlazos requested a review from eellison June 8, 2025 06:34
@mlazos mlazos force-pushed the mlazos/fuse-window branch 2 times, most recently from 6e095f5 to 3963354 Compare June 8, 2025 06:42
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

if you figure out what the one dynamic shape regression is, maybe file issue for posterity.

Copy link
Member

@Raymo111 Raymo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O(n^2) down to O(n). Insane speedup in jobs. LGTM.

@mlazos mlazos force-pushed the mlazos/fuse-window branch from 3963354 to 37f6e05 Compare June 9, 2025 19:25
@facebook-github-bot
Copy link
Contributor

@mlazos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mlazos
Copy link
Contributor Author

mlazos commented Jun 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / unit-test / linux-jammy-cpu-py3.12-gcc11-inductor-halide / build

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

@mlazos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mlazos
Copy link
Contributor Author

mlazos commented Jun 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mlazos
Copy link
Contributor Author

mlazos commented Jun 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the mlazos/fuse-window branch July 13, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants