Skip to content

Conversation

CuiYifeng
Copy link
Contributor

@CuiYifeng CuiYifeng commented Jun 16, 2025

There is a memory layout mismatching between fft_r2c XPU and Inductor meta deducing.
Original fft_r2c Inductor meta deducing for XPU backend is aligned with CPU (fallback). This PR is to correct the Inductor meta deducing and update the torch-xpu-ops commit to intel/torch-xpu-ops@3a9419c.
The XPU implementation first performs the R2C transform on the last dimension, followed by iterative C2C transforms on the remaining dimensions.

Copy link

pytorch-bot bot commented Jun 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156048

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8875a94 with merge base 96df866 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@CuiYifeng
Copy link
Contributor Author

@etaf Please help review, thanks.

@etaf etaf added the ciflow/xpu Run XPU CI tasks label Jun 16, 2025
@etaf
Copy link
Collaborator

etaf commented Jun 16, 2025

Let's put the torch-xpu-ops commit pin update which supports fft in this PR.

@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Jun 18, 2025
@CuiYifeng
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased yifeng/fft_r2c_meta_cal onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout yifeng/fft_r2c_meta_cal && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the yifeng/fft_r2c_meta_cal branch from 95c27ce to 074c252 Compare June 18, 2025 05:38
@CuiYifeng
Copy link
Contributor Author

Let's put the torch-xpu-ops commit pin update which supports fft in this PR.

@etaf The commit pin has been updated.

@etaf etaf added the ciflow/xpu Run XPU CI tasks label Jun 18, 2025
@etaf
Copy link
Collaborator

etaf commented Jun 18, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased yifeng/fft_r2c_meta_cal onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout yifeng/fft_r2c_meta_cal && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the yifeng/fft_r2c_meta_cal branch from 074c252 to a1bb459 Compare June 18, 2025 06:29
@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Jun 18, 2025
@etaf etaf added the ciflow/xpu Run XPU CI tasks label Jun 18, 2025
Copy link

pytorch-bot bot commented Jun 18, 2025

To add the ciflow label ciflow/xpu please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Jun 18, 2025
@CuiYifeng CuiYifeng changed the title Align meta calculation for fft_r2c with fft_r2c_mkl on XPU Align meta deducing for fft_r2c with fft_r2c_mkl on XPU Jun 18, 2025
@guangyey guangyey added ciflow/xpu Run XPU CI tasks release notes: xpu release notes category labels Jun 18, 2025
@guangyey guangyey moved this to Pre-Review Required in PyTorch Intel Jun 18, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Jun 19, 2025
@guangyey guangyey added ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks labels Jun 19, 2025
Copy link

pytorch-bot bot commented Jun 19, 2025

To add the ciflow label ciflow/xpu please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link

pytorch-bot bot commented Jun 19, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed ciflow/xpu Run XPU CI tasks ciflow/trunk Trigger trunk jobs on your pull request labels Jun 19, 2025
@guangyey guangyey added ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks labels Jun 19, 2025
Copy link

pytorch-bot bot commented Jun 19, 2025

To add the ciflow label ciflow/xpu please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Jun 19, 2025
@guangyey guangyey requested a review from jansel June 19, 2025 06:53
@guangyey
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #156048, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@CuiYifeng
Copy link
Contributor Author

The failed case should be irrelevant to this PR.

@guangyey
Copy link
Collaborator

"Only XPU code change, the failed case should be irrelevant to this PR."
@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-jammy-py3.9-clang12 / test (dynamo_wrapped, 3, 3, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-project-automation github-project-automation bot moved this from Review Required to Done in PyTorch Intel Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source release notes: xpu release notes category
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants