Skip to content

added stubs for jit tree views #156504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

added stubs for jit tree views #156504

wants to merge 5 commits into from

Conversation

morrison-turnansky
Copy link
Contributor

@morrison-turnansky morrison-turnansky commented Jun 20, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jun 20, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 20, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156504

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a4706dc with merge base e1f28fe (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 20, 2025
@morrison-turnansky morrison-turnansky mentioned this pull request Jun 20, 2025
Closed
@jerryzh168 jerryzh168 requested a review from ezyang June 21, 2025 00:33
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 21, 2025
@ezyang
Copy link
Contributor

ezyang commented Jun 23, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Jun 23, 2025
@morrison-turnansky
Copy link
Contributor Author

@ezyang I fixed the test. Thank you for the review.

@ezyang
Copy link
Contributor

ezyang commented Jun 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 24, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Jun 24, 2025
@morrison-turnansky
Copy link
Contributor Author

@ezyang Apologies on the linting issues, I am new to this repository. All of them have been corrected when I run them locally.

I do have one question. Ruff is flagging when I use List for type annotation and says I should use list. This is generally correct. However PyTorch supports python 3.8, and list is enabled for python type annotation starting in 3.9 according to PEP 585. On this most recent commit, I updated to use the modern list annotation. Should we be concerned about backwards compatibility?

@ezyang
Copy link
Contributor

ezyang commented Jun 25, 2025

When we import future annotations the new syntax is OK, so we can live in the future :)

@ezyang
Copy link
Contributor

ezyang commented Jun 25, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 25, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

skarjala pushed a commit to skarjala/pytorch that referenced this pull request Jun 25, 2025
@morrison-turnansky @skarjala
added stubs for jit tree views (pytorch#156504)
ced5a37 
Fixes pytorch#156488

Pull Request resolved: pytorch#156504
Approved by: https://github.com/ezyang
@morrison-turnansky morrison-turnansky deleted the mypy-issue branch June 26, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stub for mypy-torch._C._jit_tree_views
6 participants
@morrison-turnansky @ezyang @pytorchmergebot @jerryzh168 @facebook-github-bot @pytorchbot