Skip to content

[dynamo] Better error for invalid @contextlib.contextmanager usage #156924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Jun 26, 2025

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156924

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 550d5a4 with merge base 1eea2c4 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jansel added a commit that referenced this pull request Jun 26, 2025
@jansel jansel requested a review from williamwen42 June 26, 2025 04:37
@jansel jansel added the topic: not user facing topic category label Jun 26, 2025
[ghstack-poisoned]
jansel added a commit that referenced this pull request Jun 26, 2025
@jansel jansel requested a review from williamwen42 June 26, 2025 18:35
@jansel
Copy link
Contributor Author

jansel commented Jun 26, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 26, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

@jansel
Copy link
Contributor Author

jansel commented Jun 26, 2025

@pytorchbot merge -i

@jansel
Copy link
Contributor Author

jansel commented Jun 27, 2025

@pytorchbot revert -m 'Likely same issue as #156963' -c ignoredsignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jun 27, 2025
…usage (#156924)"

This reverts commit 863327a.

Reverted #156924 on behalf of https://github.com/jansel due to Likely same issue as #156963 ([comment](#156924 (comment)))
@pytorchmergebot
Copy link
Collaborator

@jansel your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added the ci-no-td Do not run TD on this PR label Jun 27, 2025
[ghstack-poisoned]
jansel added a commit that referenced this pull request Jun 27, 2025
@jansel
Copy link
Contributor Author

jansel commented Jun 27, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral), trunk / win-vs2022-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@jansel
Copy link
Contributor Author

jansel commented Jun 27, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo Reverted topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants