Skip to content

remove allow-untyped-defs from torch/ao/nn/quantized/modules/rnn.py #157234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

remove allow-untyped-defs from torch/ao/nn/quantized/modules/rnn.py #157234

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45c69a6
Update
bobrenjc93 Jun 29, 2025
424bef2
Update
bobrenjc93 Jun 29, 2025
4ca820f
Update
bobrenjc93 Jun 30, 2025
480445f
Update
bobrenjc93 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions torch/ao/nn/quantized/modules/rnn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# mypy: allow-untyped-defs
from typing import Any

import torch


Expand Down Expand Up @@ -35,11 +36,11 @@ class LSTM(torch.ao.nn.quantizable.LSTM):

_FLOAT_MODULE = torch.ao.nn.quantizable.LSTM # type: ignore[assignment]

def _get_name(self):
def _get_name(self) -> str:
return "QuantizedLSTM"

@classmethod
def from_float(cls, *args, **kwargs):
def from_float(cls, *args: Any, **kwargs: Any) -> None:
# The whole flow is float -> observed -> quantized
# This class does observed -> quantized only
raise NotImplementedError(
Expand All @@ -49,7 +50,7 @@ def from_float(cls, *args, **kwargs):
)

@classmethod
def from_observed(cls, other):
def from_observed(cls: type["LSTM"], other: torch.ao.nn.quantizable.LSTM) -> "LSTM":
assert isinstance(other, cls._FLOAT_MODULE) # type: ignore[has-type]
converted = torch.ao.quantization.convert(
other, inplace=False, remove_qconfig=True
Expand Down
Loading