Add einops x torch.compile testing in PyTorch CI #157416

zou3519 · 2025-07-02T01:36:07Z

Stack from ghstack (oldest at bottom):

-> Add einops x torch.compile testing in PyTorch CI #157416

Fixes #146782. This PR adds testing for multiple einops versions in
PyTorch CI. This occurs in a new "einops" CI job that runs for both
Python 3.9 and 3.13 (aka, what we test Dynamo over).

Test Plan:

wait for CI

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI [ghstack-poisoned]

pytorch-bot · 2025-07-02T01:36:11Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157416

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit db6a8ed with merge base 0f9c1b3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI ghstack-source-id: cb924f8 Pull Request resolved: #157416

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

zou3519 · 2025-07-02T13:01:35Z

cc @arogozhnikov

guilhermeleobas · 2025-07-02T14:11:25Z

test/dynamo/test_einops.py

+    einops_version = einops.__version__
+else:
+    einops_version = "none"
+    print("einops not available, skipping tests", file=sys.stderr)


Remove? As @skipIf will print to stderr if einops is not available.

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI ghstack-source-id: 47d785f Pull Request resolved: #157416

arogozhnikov

looks good, I'm sure this will be helpful.
Thank you @zou3519 @guilhermeleobas

arogozhnikov · 2025-07-03T06:23:15Z

test/dynamo/test_einops.py

+        addition = einsum(x_abc, x_abcd, suf("a b c , a b c d -> d"))[0]
+        return x1 + addition
+
+compiled_fn = torch.compile(TorchModuleWithOperations())


do you want to put fullgraph here as well? No opinion, just asking

thank you, I missed that

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI ghstack-source-id: ce454e2 Pull Request resolved: #157416

zou3519 · 2025-07-03T16:16:52Z

@pytorchbot merge

pytorchmergebot · 2025-07-03T16:18:39Z

Merge failed

Reason: Approvers from one of the following sets are needed:

superuser (pytorch/metamates)
Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

anijain2305

Thank you so much for leading this!

zou3519 · 2025-07-03T17:29:17Z

@pytorchbot merge

pytorchmergebot · 2025-07-03T17:31:04Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

zou3519 · 2025-07-03T20:43:18Z

@pytorchbot cherry-pick --onto release/2.8 -c critical

pytorchbot · 2025-07-03T20:49:10Z

Cherry picking #157416

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x e3fe001d9e38153a7797ad25377fdfa34e461113 returned non-zero exit code 1

Auto-merging .ci/pytorch/test.sh
CONFLICT (content): Merge conflict in .ci/pytorch/test.sh
Auto-merging .github/workflows/pull.yml
error: could not apply e3fe001d9e3... Add einops x torch.compile testing in PyTorch CI (#157416)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI Pull Request resolved: #157416 Approved by: https://github.com/guilhermeleobas, https://github.com/arogozhnikov, https://github.com/anijain2305

Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. Pull Request resolved: #157600 Approved by: https://github.com/guilhermeleobas, https://github.com/anijain2305 ghstack dependencies: #157416

Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. Pull Request resolved: #157600 Approved by: https://github.com/guilhermeleobas, https://github.com/anijain2305 ghstack dependencies: #157416 (cherry picked from commit 5d8d126)

Fix einops x torch.compile interaction (#157600) Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. Pull Request resolved: #157600 Approved by: https://github.com/guilhermeleobas, https://github.com/anijain2305 ghstack dependencies: #157416 (cherry picked from commit 5d8d126) Co-authored-by: rzou <zou3519@gmail.com>

Add einops x torch.compile testing in PyTorch CI

0a364a0

Fixes #146782. This PR adds testing for multiple einops versions in PyTorch CI. This occurs in a new "einops" CI job that runs for both Python 3.9 and 3.13 (aka, what we test Dynamo over). Test Plan: - wait for CI [ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo release notes: releng release notes category labels Jul 2, 2025

zou3519 marked this pull request as ready for review July 2, 2025 12:59

zou3519 requested a review from a team as a code owner July 2, 2025 12:59

zou3519 requested review from guilhermeleobas and anijain2305 July 2, 2025 12:59

zou3519 mentioned this pull request Jul 2, 2025

Dynamo's einops version check is bogus #157451

Closed

guilhermeleobas approved these changes Jul 2, 2025

View reviewed changes

zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 2, 2025

arogozhnikov approved these changes Jul 3, 2025

View reviewed changes

pytorchmergebot added the merging label Jul 3, 2025

pytorchmergebot removed the merging label Jul 3, 2025

anijain2305 approved these changes Jul 3, 2025

View reviewed changes

pytorchmergebot added the merging label Jul 3, 2025

pytorchmergebot closed this in e3fe001 Jul 3, 2025

pytorchmergebot added Merged and removed merging labels Jul 3, 2025

This was referenced Jul 3, 2025

Add einops x torch.compile testing in PyTorch CI (#157416) #157588

Merged

[v.2.8.0] Release Tracker #156745

Open

Fix einops x torch.compile interaction #157600

Closed

pytorchbot mentioned this pull request Jul 8, 2025

Fix einops x torch.compile interaction #157754

Merged

guilhermeleobas mentioned this pull request Jul 8, 2025

[einops] Ensure Dynamo can trace through einops #155310

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add einops x torch.compile testing in PyTorch CI #157416

Add einops x torch.compile testing in PyTorch CI #157416

Uh oh!

zou3519 commented Jul 2, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

zou3519 commented Jul 2, 2025

Uh oh!

guilhermeleobas Jul 2, 2025

Uh oh!

arogozhnikov left a comment

Uh oh!

arogozhnikov Jul 3, 2025

Uh oh!

zou3519 Jul 3, 2025

Uh oh!

zou3519 commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Uh oh!

anijain2305 left a comment

Uh oh!

zou3519 commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Uh oh!

zou3519 commented Jul 3, 2025

Uh oh!

pytorchbot commented Jul 3, 2025

Uh oh!

Uh oh!

Add einops x torch.compile testing in PyTorch CI #157416

Add einops x torch.compile testing in PyTorch CI #157416

Uh oh!

Conversation

zou3519 commented Jul 2, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157416

✅ No Failures

Uh oh!

zou3519 commented Jul 2, 2025

Uh oh!

guilhermeleobas Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

arogozhnikov left a comment

Choose a reason for hiding this comment

Uh oh!

arogozhnikov Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

zou3519 Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

zou3519 commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Merge failed

Uh oh!

anijain2305 left a comment

Choose a reason for hiding this comment

Uh oh!

zou3519 commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Merge started

Uh oh!

zou3519 commented Jul 3, 2025

Uh oh!

pytorchbot commented Jul 3, 2025

Cherry picking #157416

Uh oh!

Uh oh!

zou3519 commented Jul 2, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jul 2, 2025 •

edited

Loading