Migrate c10/macros/cmake_macros.h.in to torch/headeronly #158035
Closed
+183
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158035
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7f8f139 with merge base 4f36743 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
janeyx99
force-pushed
the
export-D78016591
branch
from
405accb to
5b01bfa
Compare
janeyx99
added a commit
to janeyx99/pytorch
that referenced
this pull request
Jul 10, 2025
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
janeyx99
force-pushed
the
export-D78016591
branch
from
5b01bfa to
7427cdd
Compare
janeyx99
added a commit
to janeyx99/pytorch
that referenced
this pull request
Jul 14, 2025
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
janeyx99
added a commit
to janeyx99/pytorch
that referenced
this pull request
Jul 14, 2025
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
janeyx99
force-pushed
the
export-D78016591
branch
from
7427cdd to
3e8cc3d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
janeyx99
added a commit
to janeyx99/pytorch
that referenced
this pull request
Jul 14, 2025
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
janeyx99
force-pushed
the
export-D78016591
branch
from
3e8cc3d to
2d23136
Compare
swolchok
approved these changes
Jul 14, 2025
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
janeyx99
force-pushed
the
export-D78016591
branch
from
2d23136 to
8279d35
Compare
janeyx99
added a commit
to janeyx99/pytorch
that referenced
this pull request
Jul 15, 2025
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
janeyx99
added a commit
to janeyx99/pytorch
that referenced
this pull request
Jul 15, 2025
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
janeyx99
force-pushed
the
export-D78016591
branch
from
8279d35 to
effff0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
janeyx99
added a commit
to janeyx99/pytorch
that referenced
this pull request
Jul 15, 2025
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
janeyx99
force-pushed
the
export-D78016591
branch
from
effff0d to
1a6b863
Compare
) Summary: Pull Request resolved: pytorch#158035 As above, also changes a bunch of the build files to be better Test Plan: internal and external CI did run buck2 build fbcode//caffe2:torch and it succeeded Rollback Plan: Reviewed By: swolchok Differential Revision: D78016591
|
This pull request was exported from Phabricator. Differential Revision: D78016591 |
janeyx99
force-pushed
the
export-D78016591
branch
from
1a6b863 to
7f8f139
Compare
This was referenced Jul 15, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As above, also changes a bunch of the build files to be better
Test Plan:
internal and external CI
did run buck2 build fbcode//caffe2:torch and it succeeded
Rollback Plan:
Reviewed By: swolchok
Differential Revision: D78016591