Skip to content

[BE] document Adadelta and Adagrad APIs properly #158483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[BE] document Adadelta and Adagrad APIs properly #158483

wants to merge 4 commits into from
+45 −16

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 16, 2025 •
edited
Loading

@janeyx99 janeyx99 requested a review from albanD as a code owner July 16, 2025 20:58
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158483

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7503a5d with merge base a9ee425 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Jul 16, 2025
@janeyx99
[BE] document Adadelta and Adagrad APIs properly
1fea2ef 
ghstack-source-id: effe423
Pull Request resolved: #158483
albanD
albanD approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

janeyx99 added a commit that referenced this pull request Jul 18, 2025
@janeyx99
[BE] document Adadelta, Adam, and Adagrad APIs properly
442ffa1 
ghstack-source-id: 8dd98ab
Pull Request resolved: #158483
janeyx99 added a commit that referenced this pull request Jul 18, 2025
@janeyx99
[BE] document Adadelta, Adam, and Adagrad APIs properly
f08d4b3 
ghstack-source-id: 1f9b07d
Pull Request resolved: #158483
janeyx99 added a commit that referenced this pull request Jul 18, 2025
@janeyx99
[BE] document Adadelta, Adam, and Adagrad APIs properly
7c1a4d2 
ghstack-source-id: 8ec0efc
Pull Request resolved: #158483
@janeyx99 janeyx99 mentioned this pull request Jul 18, 2025
Closed
@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 19, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158669

pytorchmergebot pushed a commit that referenced this pull request Jul 19, 2025
@janeyx99 @pytorchmergebot
Document the rest of the specific optimizer module APIs (#158669)
7cc5d03 
Pull Request resolved: #158669
Approved by: https://github.com/albanD
ghstack dependencies: #158483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: optim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janeyx99 @pytorchmergebot @albanD