[MPS] Reimplement tri[ul] as Metal shaders
#158867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add in-place flavor, as it is currently broken for non-contig tensors Pull Request resolved: #157179 Approved by: https://github.com/dcci (cherry picked from commit a1e4f1f)
This was referenced Jul 22, 2025
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158867
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 52 PendingAs of commit 342aa8f with merge base 3a7ff82 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Jul 22, 2025
79 tasks
tvukovic-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Aug 20, 2025
[MPS] Reimplement `tri[ul]` as Metal shaders (pytorch#157179) And add in-place flavor, as it is currently broken for non-contig tensors Pull Request resolved: pytorch#157179 Approved by: https://github.com/dcci (cherry picked from commit a1e4f1f) Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add in-place flavor, as it is currently broken for non-contiguous tensors.