Skip to content

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jul 28, 2025

Fix and reland #158613, I keep checkout_install_torchbench in .ci/pytorch/macos-test.sh script because it's still used there, and there is no Docker.

Testing

MacOS perf nightly run https://github.com/pytorch/pytorch/actions/runs/16580798470

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

huydhn added 30 commits July 17, 2025 15:51
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Copy link

pytorch-bot bot commented Jul 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159300

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 7 New Failures

As of commit aa19897 with merge base 6100ed4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Jul 28, 2025
@huydhn huydhn added no-runner-experiments Bypass Meta/LF runner determinator and removed test-config/default labels Jul 28, 2025
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn requested a review from clee2000 July 29, 2025 03:22
@XuehaiPan XuehaiPan added ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request ciflow/torchbench labels Jul 29, 2025
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn requested a review from ZainRizvi August 5, 2025 19:35
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff since take 1 looks reasonable. I trust you to make sure whether the docker failures are relevant or not

@huydhn
Copy link
Contributor Author

huydhn commented Aug 5, 2025

cc @atalman I'm pretty sure the Docker image validation failures is not related, but not sure why it shows up in PR. Maybe that workflow is not meant to be run on PR (@XuehaiPan added the ciflow/nightly label to the PR)

@huydhn
Copy link
Contributor Author

huydhn commented Aug 5, 2025

@pytorchbot merge -i

@huydhn
Copy link
Contributor Author

huydhn commented Aug 5, 2025

cc @anijain2305 I'm re-landing this PR today, so I suspect that you might want to rebase #159291 before landing it. There shouldn't be any major change, this PR just move TorchBench installation during test time into the Docker build time.

@jithunnair-amd
Copy link
Collaborator

@huydhn This PR seems to have had a collateral impact on the only numpy2-based workflow that runs GPU tests: https://github.com/pytorch/pytorch/actions/runs/16763863956/job/47469669670

@huydhn
Copy link
Contributor Author

huydhn commented Aug 7, 2025

@huydhn This PR seems to have had a collateral impact on the only numpy2-based workflow that runs GPU tests: https://github.com/pytorch/pytorch/actions/runs/16763863956/job/47469669670

Yes, you're right. @izaitsevfb has notified me earlier about the same issue. As this PR has lots of touch points across multiple workflows. I propose that we forward fix it in #160047. Basically, the regular ROCm CI job doesn't need to include the baggage from TorchBench.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/torchbench ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch no-runner-experiments Bypass Meta/LF runner determinator release notes: releng release notes category test-config/default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants