Fix get_free_symbol_uses for several nodes #160314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160314
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6e19a3b with merge base ecea811 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
laithsakka
requested review from
kundaMwiza
and removed request for
kundaMwiza
eellison
approved these changes
Aug 11, 2025
torch/_inductor/ir.py
Outdated
Comment on lines
5369
to
5372
| def get_free_symbol_uses( | ||
| self, unbacked_only: bool = False | ||
| ) -> OrderedSet[sympy.Symbol]: | ||
| return NopKernel.get_free_symbol_uses(self, unbacked_only) |
There was a problem hiding this comment.
Indented incorrectly ? Also This is dead code, (should already be defined through inheritance)
eellison
reviewed
Aug 11, 2025
benchmarks/dynamo/pr_time_benchmarks/benchmarks/basic_modules_benchmarks.py
Outdated
Show resolved
Hide resolved
laithsakka
commented
Aug 12, 2025
|
|
||
|
|
||
|
|
||
| basic_NestedModule_eager,compile_time_instruction_count,9199000000,0.1 | ||
| basic_NestedModule_eager,compile_time_instruction_count,9554000000,0.1 |
There was a problem hiding this comment.
exisiting not from my PR.
|
Fix the perf regression |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge |
|
Can't merge closed PR #160314 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 14, 2025
regression introduced by #160314 not much worried about it since it did not effect other inductor benchmarks could not repo locally Pull Request resolved: #160537 Approved by: https://github.com/eellison
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 14, 2025
get_free_symbol_uses is used to know what unbacked symbols are used by a given node. not having correct get_free_symbol_uses defined properly leads to : - eliminating of some nodes due to not detection of any users. (See the added unit test) - Incorrect topological sort. Fix get_free_symbol_uses , NopKernel , ConcarKernel, InputsKerenl, external kernel. for ComputedBuffer with NonOwningLayout its interesting case. when layout is NonOwningLayout we need to access the actual view op base layout and use detect symbols in it. Because when we codegen the ComputedBuffer we uses those symbols. Pull Request resolved: #160314 Approved by: https://github.com/eellison
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 14, 2025
regression introduced by #160314 not much worried about it since it did not effect other inductor benchmarks could not repo locally Pull Request resolved: #160537 Approved by: https://github.com/eellison
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 18, 2025
get_free_symbol_uses is used to know what unbacked symbols are used by a given node. not having correct get_free_symbol_uses defined properly leads to : - eliminating of some nodes due to not detection of any users. (See the added unit test) - Incorrect topological sort. Fix get_free_symbol_uses , NopKernel , ConcarKernel, InputsKerenl, external kernel. for ComputedBuffer with NonOwningLayout its interesting case. when layout is NonOwningLayout we need to access the actual view op base layout and use detect symbols in it. Because when we codegen the ComputedBuffer we uses those symbols. Pull Request resolved: #160314 Approved by: https://github.com/eellison
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 18, 2025
regression introduced by #160314 not much worried about it since it did not effect other inductor benchmarks could not repo locally Pull Request resolved: #160537 Approved by: https://github.com/eellison
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
get_free_symbol_uses is used to know what unbacked symbols are used by a given node. not having correct get_free_symbol_uses defined properly leads to : - eliminating of some nodes due to not detection of any users. (See the added unit test) - Incorrect topological sort. Fix get_free_symbol_uses , NopKernel , ConcarKernel, InputsKerenl, external kernel. for ComputedBuffer with NonOwningLayout its interesting case. when layout is NonOwningLayout we need to access the actual view op base layout and use detect symbols in it. Because when we codegen the ComputedBuffer we uses those symbols. Pull Request resolved: pytorch#160314 Approved by: https://github.com/eellison
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
regression introduced by pytorch#160314 not much worried about it since it did not effect other inductor benchmarks could not repo locally Pull Request resolved: pytorch#160537 Approved by: https://github.com/eellison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
get_free_symbol_uses is used to know what unbacked symbols are used by a given node.
not having correct get_free_symbol_uses defined properly leads to :
Fix get_free_symbol_uses , NopKernel , ConcarKernel, InputsKerenl, external kernel.
for ComputedBuffer with NonOwningLayout its interesting case.
when layout is NonOwningLayout we need to access the actual view op base layout and use
detect symbols in it. Because when we codegen the ComputedBuffer we uses those symbols.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela