Skip to content

Conversation

NikhilAPatel
Copy link
Contributor

@NikhilAPatel NikhilAPatel commented Aug 25, 2025

Summary: Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke knobs.runtime.jit_post_compile_hook if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 config variable.

Reviewed By: davidberard98

Differential Revision: D80624932

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Copy link

pytorch-bot bot commented Aug 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161443

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit 02168bb with merge base e6aa728 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80624932

NikhilAPatel added a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
Summary:
X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98

Differential Revision: D80624932
@NikhilAPatel NikhilAPatel added the topic: not user facing topic category label Aug 25, 2025
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! please fix the lint error before land.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 25, 2025
facebook-github-bot pushed a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
…th (#83)

Summary:

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98

Differential Revision: D80624932
NikhilAPatel added a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
…th (#83)

Summary:

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98

Differential Revision: D80624932
NikhilAPatel added a commit to NikhilAPatel/pytorch that referenced this pull request Aug 25, 2025
…Triton Kernel compile path (pytorch#161443)

Summary:
X-link: meta-pytorch/tritonparse#83


Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98

Differential Revision: D80624932
NikhilAPatel added a commit to NikhilAPatel/pytorch that referenced this pull request Aug 25, 2025
…Triton Kernel compile path (pytorch#161443)

Summary:
X-link: meta-pytorch/tritonparse#83


Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98

Differential Revision: D80624932
@NikhilAPatel NikhilAPatel force-pushed the export-D80624932 branch 2 times, most recently from f8b9b61 to b481724 Compare August 25, 2025 21:50
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80624932

NikhilAPatel added a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
…th (#83)

Summary:
Pull Request resolved: #83

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80624932

NikhilAPatel added a commit to NikhilAPatel/pytorch that referenced this pull request Aug 25, 2025
…Triton Kernel compile path (pytorch#161443)

Summary:
X-link: meta-pytorch/tritonparse#83

Pull Request resolved: pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
NikhilAPatel added a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
…th (#83)

Summary:

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
NikhilAPatel added a commit to NikhilAPatel/pytorch that referenced this pull request Aug 25, 2025
…Triton Kernel compile path (pytorch#161443)

Summary:
X-link: meta-pytorch/tritonparse#83


Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
NikhilAPatel added a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
…th (#83)

Summary:
Pull Request resolved: #83

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80624932

NikhilAPatel added a commit to NikhilAPatel/pytorch that referenced this pull request Aug 25, 2025
…Triton Kernel compile path (pytorch#161443)

Summary:
X-link: meta-pytorch/tritonparse#83

Pull Request resolved: pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
NikhilAPatel added a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
…th (#83)

Summary:

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
NikhilAPatel added a commit to NikhilAPatel/pytorch that referenced this pull request Aug 25, 2025
…Triton Kernel compile path (pytorch#161443)

Summary:
X-link: meta-pytorch/tritonparse#83


Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
…Triton Kernel compile path (pytorch#161443)

Summary:
X-link: meta-pytorch/tritonparse#83

Pull Request resolved: pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
NikhilAPatel added a commit to meta-pytorch/tritonparse that referenced this pull request Aug 25, 2025
…th (#83)

Summary:
Pull Request resolved: #83

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80624932

facebook-github-bot pushed a commit to meta-pytorch/tritonparse that referenced this pull request Aug 26, 2025
…th (#83)

Summary:
Pull Request resolved: #83

X-link: pytorch/pytorch#161443

Since Inductor skips JIT compilation for Triton kernels, we need to manually invoke `knobs.runtime.jit_post_compile_hook` if one exists. Here, we do this to enable Tritonparse to extract launch metadata from Inductor launched kernels. We can control whether or not Inductor will run the hook with a new `TORCHINDUCTOR_RUN_JIT_POST_COMPILE_HOOK=1 ` config variable.

Reviewed By: davidberard98, FindHao

Differential Revision: D80624932

fbshipit-source-id: 57cd14f3facf053fe1c02b15f04f0ea4c1b68198
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants