Skip to content

[ROCm] revamp miopen integration #161687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[ROCm] revamp miopen integration #161687

wants to merge 9 commits into from
+1,163 −769

Conversation

ethanwee1
Copy link
Contributor

@ethanwee1 ethanwee1 commented Aug 28, 2025 •
edited by pytorch-bot bot
Loading

Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @albanD

@jeffdaily
[ROCm] revamp miopen integration
ddaca83 
Update sources under ATen/miopen and ATen/native/miopen to align with
best practices. Avoid reshape_ calls inside backward operations.
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161687

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 30b9d6a with merge base 8703deb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: cpu CPU specific problem (e.g., perf, algorithm) module: rocm AMD GPU support for Pytorch labels Aug 28, 2025
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@jeffdaily jeffdaily added the release notes: rocm mandatorylabel label Aug 28, 2025
@jeffdaily jeffdaily added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 labels Aug 28, 2025
@pytorch-bot PyTorch Bot

This comment was marked as outdated.

Sign in to view
@pytorch-bot pytorch-bot bot removed the ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 label Aug 28, 2025
@jeffdaily jeffdaily added the ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 label Aug 28, 2025
@pytorch-bot pytorch-bot bot removed ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 labels Aug 28, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 skip-pr-sanity-checks labels Aug 28, 2025
@albanD
Copy link
Collaborator

albanD commented Aug 28, 2025

Why skipping PR sanity check is ok here? We would expect a script to repro the change/codemod and regular file move usually.
cc @seemethere

@jeffdaily
Copy link
Collaborator

jeffdaily commented Aug 28, 2025 •
edited
Loading

Why skipping PR sanity check is ok here? We would expect a script to repro the change/codemod and regular file move usually. cc @seemethere

@albanD Did I add the wrong label? PR SIZE is 2598, so over the 2000 limit. This PR is very difficult to break into smaller pieces, and a big chunk of the diff is removing miopen depthwise redundant code.

@seemethere
Copy link
Member

Why skipping PR sanity check is ok here? We would expect a script to repro the change/codemod and regular file move usually. cc @seemethere

@albanD Did I add the wrong label? PR SIZE is 2598, so over the 2000 limit. This PR is very difficult to break into smaller pieces, and a big chunk of the diff is removing miopen depthwise redundant code.

Is the removal stuff something we can do in a separate PR?

@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Aug 29, 2025
@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Aug 29, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Aug 29, 2025
@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 2, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 2, 2025
@jeffdaily jeffdaily marked this pull request as ready for review September 3, 2025 16:46
@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 3, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jeffdaily added a commit to ROCm/pytorch that referenced this pull request Sep 4, 2025
@jeffdaily
[release/2.7] revamp miopen integration
cc37dc8 
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations.

Pull Request resolved: pytorch#161687
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jeffdaily added a commit to ROCm/pytorch that referenced this pull request Sep 4, 2025
@jeffdaily
[release/2.7] revamp miopen integration
b3f843f 
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations.

Pull Request resolved: pytorch#161687
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jeffdaily added a commit to ROCm/pytorch that referenced this pull request Sep 4, 2025
@jeffdaily
[release/2.8] revamp miopen integration
54e7000 
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations.

Pull Request resolved: pytorch#161687
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
@jeffdaily jeffdaily mentioned this pull request Sep 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

Assignees
No one assigned
Labels
ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: rocm AMD GPU support for Pytorch open source release notes: rocm mandatorylabel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ethanwee1 @albanD @jeffdaily @seemethere @pytorchmergebot @pytorchbot