Skip to content

Conversation

anshul-si
Copy link
Contributor

@anshul-si anshul-si commented Oct 7, 2025

Summary: Created a test so that we can verify that a model that has been pipelined + replicated has the same gradients as a reference model. To do this, I mapped the layers and their parameters in each partial model to the original full model and then compared the gradients.

Test Case

  1. pytest test/distributed/_composable/test_composability/test_pp_composability.py -k test_replicate_pp_grads

Stack from ghstack (oldest at bottom):

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci

Copy link

pytorch-bot bot commented Oct 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164880

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 23 Pending

As of commit d532867 with merge base f63d16c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Oct 7, 2025
anshul-si added a commit that referenced this pull request Oct 7, 2025
…vice model grads

ghstack-source-id: ac3f1c3
Pull Request resolved: #164880
@anshul-si anshul-si requested a review from H-Huang October 7, 2025 22:03
@anshul-si anshul-si closed this Oct 7, 2025
@anshul-si anshul-si removed the request for review from H-Huang October 7, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant