Mark native_functions as matched if uncaptured by JIT #17631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
cpuhrsch
force-pushed
the
strange
branch
2 times, most recently
from
903ab12 to
b715e47
Compare
|
This causes no changes to the codegen outside of Declarations.yaml's schema_string |
There was a problem hiding this comment.
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Mar 2, 2019
There was a problem hiding this comment.
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 3, 2019
Summary: Various functions aren't used by the JIT, so they're jit-compliant w.r.t. their schema by default. Pull Request resolved: pytorch/pytorch#17631 Differential Revision: D14295559 Pulled By: cpuhrsch fbshipit-source-id: a2ecdcb5df47eb67c54ec642d88d42e985515142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various functions aren't used by the JIT, so they're jit-compliant w.r.t. their schema by default.