Skip to content

Fixing the calling parameters of write_gif function of the moviepy. #21218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixing the calling parameters of write_gif function of the moviepy. #21218

wants to merge 2 commits into from

Conversation

danielmatte
Copy link
Contributor

No description provided.

@danielmatte
Copy link
Contributor Author

Summary: When called the add_video function from SummaryWriter some messages like below are showed. This happen because in moviepy lib 1.0.0 the function write_gif was changed her prototype and now use logger=None parameter instead of progress_bar=False to run in quiet mode.

Then, make_video function, used by add_video from SummaryWrite, was changed to fix that.

MoviePy - Building file /tmp/tmpnppy8qfj.gif with imageio.
t: 30%|████████████████████████████████▋
MoviePy - Building file /tmp/tmpb49a791a.gif with imageio.
MoviePy - Building file /tmp/tmp0hwqembz.gif with imageio.
MoviePy - Building file /tmp/tmp1tk8x0ve.gif with imageio.
MoviePy - Building file /tmp/tmp6_8cp843.gif with imageio.

@ezyang ezyang requested a review from lanpa June 6, 2019 16:45
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 6, 2019
@danielmatte
Copy link
Contributor Author

no news about this PR? @ezyang @lanpa

ezyang
ezyang approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. Sure, why not.

facebook-github-bot
facebook-github-bot reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 557246b.

mingbowan pushed a commit to mingbowan/pytorch that referenced this pull request Sep 23, 2019
@danielmatte
Fixing the calling parameters of write_gif function of the moviepy.
309ab4b 
Summary: Pull Request resolved: pytorch#21218

Differential Revision: D17509260

Pulled By: ezyang

fbshipit-source-id: 51e392cbcc20ade4c38c4edb75919f9bb314a830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

@lanpa lanpa Awaiting requested review from lanpa

Assignees
No one assigned
Labels
Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielmatte @facebook-github-bot @ezyang @mruberry