Skip to content

Prevent VS from emitting errors when using swap in Optional.h #22182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Prevent VS from emitting errors when using swap in Optional.h #22182

wants to merge 1 commit into from

Conversation

peterjc123
Copy link
Collaborator

Fixes #21706

@peterjc123 peterjc123 requested a review from ezyang June 25, 2019 02:49
@pytorchbot pytorchbot added the module: internals Related to internal abstractions in c10 and ATen label Jun 25, 2019
facebook-github-bot
facebook-github-bot reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@soumith soumith added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 25, 2019
@peterjc123
Copy link
Collaborator Author

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Jun 26, 2019
@peterjc123 peterjc123 mentioned this pull request Jun 26, 2019
Closed
@peterjc123 peterjc123 deleted the optional_swap_fix branch June 26, 2019 14:35
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 95b5718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@soumith soumith soumith approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
merge-this-please Was marked for merge with @pytorchbot merge this please Merged module: internals Related to internal abstractions in c10 and ATen open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: Optional.h(519): error C2660: 'c10::optional<bool>::swap': function does not take 2 arguments
6 participants
@peterjc123 @facebook-github-bot @soumith @ezyang @pytorchbot @mruberry