Skip to content

Updated docs and added deprecation warnings to acknowledge a bool tensor #22261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Updated docs and added deprecation warnings to acknowledge a bool tensor #22261

wants to merge 20 commits into from

Conversation

izdeby
Copy link
Contributor

@izdeby izdeby commented Jun 26, 2019 •
edited
Loading

Stack from ghstack:

Change:

  • Updated docs to mention bool tensor functionality.
  • Added deprecation warnings to masked methods.

Differential Revision: D16005990

@pytorchbot pytorchbot added module: cuda Related to torch.cuda, and CUDA support in general module: docs Related to our documentation, both in docs/ and docblocks module: operators labels Jun 26, 2019
@izdeby izdeby changed the title Updated docs to acknowledge a bool tensor Updated docs and added deprecation warnings to acknowledge a bool tensor Jun 26, 2019
@izdeby izdeby requested review from gchanan, ssnl, li-roy, ezyang and VitalyFedyunin and removed request for gchanan and ssnl June 26, 2019 14:22
@izdeby izdeby mentioned this pull request Jun 26, 2019
Closed
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
959b25c 
… a bool tensor"

Updated docs to acknowledge a bool tensor

gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
gchanan
gchanan reviewed Jul 1, 2019
View reviewed changes
gchanan
gchanan approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@gchanan gchanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good if you change the examples.

izdeby added 2 commits July 10, 2019 20:25
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
66ee1c8 
… a bool tensor"

Updated docs to acknowledge a bool tensor

gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
99f3584 
… a bool tensor"

Updated docs to acknowledge a bool tensor

gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
@pytorchbot pytorchbot added module: typing Related to mypy type annotations labels Jul 11, 2019
izdeby added 7 commits July 11, 2019 11:27
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
d30dad0 
… a bool tensor"

Updated docs to acknowledge a bool tensor

gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
2b757e2 
… a bool tensor"

Updated docs to acknowledge a bool tensor

gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
79c4560 
… a bool tensor"

Updated docs to acknowledge a bool tensor

gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
ae0c84d 
… a bool tensor"

Updated docs to acknowledge a bool tensor

gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
ec26ddc 
… a bool tensor"

Stack from [ghstack](https://github.com/ezyang/ghstack):
* **#22261 Updated docs to acknowledge a bool tensor**
* #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool
-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
42a9012 
… a bool tensor"

Stack from [ghstack](https://github.com/ezyang/ghstack):
* **#22261 Updated docs to acknowledge a bool tensor**
* #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool
-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
6a25892 
… a bool tensor"

Stack from [ghstack](https://github.com/ezyang/ghstack):
* **#22261 Updated docs to acknowledge a bool tensor**
* #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool
-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
izdeby added 5 commits July 25, 2019 13:45
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
2394de5 
… a bool tensor"

Stack from [ghstack](https://github.com/ezyang/ghstack):
* **#22261 Updated docs to acknowledge a bool tensor**
* #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool
-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
9319bd9 
… a bool tensor"

Stack from [ghstack](https://github.com/ezyang/ghstack):
* **#22261 Updated docs to acknowledge a bool tensor**
* #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool
-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
fd28748 
… a bool tensor"

-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
f5f9c76 
… a bool tensor"

-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
cd9ba65 
… a bool tensor"

-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@pytorchbot pytorchbot added the module: internals Related to internal abstractions in c10 and ATen label Aug 1, 2019
izdeby added 3 commits August 1, 2019 08:40
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
25d59f9 
… a bool tensor"

-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
9599b14 
… a bool tensor"

-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
48c9502 
… a bool tensor"

-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@izdeby
Copy link
Contributor Author

izdeby commented Aug 2, 2019

@gchanan, @ezyang can you, please, take a final quick look before i land?
Lint will be fixed here, to keep this change clean.

@izdeby
Update on "Updated docs and added deprecation warnings to acknowledge…
18b836e 
… a bool tensor"

-------------
Change: 
- Updated docs to mention bool tensor functionality.
- Added deprecation warnings to masked methods.

Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
@zou3519 zou3519 deleted the gh/izdeby/11/head branch August 5, 2019 14:45
@facebook-github-bot
Copy link
Contributor

@izdeby merged this pull request in 19c6751.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 5, 2019
@izdeby @facebook-github-bot
Updated docs and added deprecation warnings to acknowledge a bool ten…
258c828 
…sor (#22261)

Summary:
Pull Request resolved: pytorch/pytorch#22261
ghimport-source-id: 1611d62d056a04c0ad15ef662e594a3d206a78e2

Test Plan: Imported from OSS

Differential Revision: D16005990

Pulled By: izdeby

fbshipit-source-id: 2413824aa75a0755719e4df11acd21e6607e5a85
izdeby added a commit that referenced this pull request Aug 5, 2019
@izdeby
Updated docs and added deprecation warnings to acknowledge a bool ten…
440220d 
…sor (#22261)

Summary:
Pull Request resolved: #22261
ghimport-source-id: 1611d62

Test Plan: Imported from OSS

Differential Revision: D16005990

Pulled By: izdeby

fbshipit-source-id: 2413824aa75a0755719e4df11acd21e6607e5a85
@izdeby izdeby mentioned this pull request Aug 5, 2019
Merged
soumith pushed a commit that referenced this pull request Aug 7, 2019
@izdeby @soumith
Updated docs and added deprecation warnings to acknowledge a bool ten…
060f677 
…sor (#22261) (#23811)

Summary:
Pull Request resolved: #22261
ghimport-source-id: 1611d62

Test Plan: Imported from OSS

Differential Revision: D16005990

Pulled By: izdeby

fbshipit-source-id: 2413824aa75a0755719e4df11acd21e6607e5a85
@malfet malfet mentioned this pull request Mar 6, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Mar 7, 2023
@malfet @pytorchmergebot
[BC] Allow only bool tensors as mask in masked_select (#96112)
1cd0929 
`byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0)
Deprecation warning was added by #22261

Also, fix bunch of syntactic errors in comments

Pull Request resolved: #96112
Approved by: https://github.com/ezyang
@kvathupo kvathupo mentioned this pull request Mar 11, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@malfet @cyyever
[BC] Allow only bool tensors as mask in masked_select (#96112)
2d4c5cb 
`byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0)
Deprecation warning was added by pytorch/pytorch#22261

Also, fix bunch of syntactic errors in comments

Pull Request resolved: pytorch/pytorch#96112
Approved by: https://github.com/ezyang
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@malfet @cyyever
[BC] Allow only bool tensors as mask in masked_select (#96112)
6f526f7 
`byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0)
Deprecation warning was added by pytorch/pytorch#22261

Also, fix bunch of syntactic errors in comments

Pull Request resolved: pytorch/pytorch#96112
Approved by: https://github.com/ezyang
pytorchmergebot pushed a commit that referenced this pull request Mar 13, 2023
@kvathupo @pytorchmergebot
Deprecate non-bool masks in masked_fill (#96594)
2b9d9bc 
__What?__
Per discussion at #94634, deprecate `masked_fill` with non-bool masks. Deprecation warnings were previously added by #22261, but not for Apple MPS. I can revert the MPS changes if deprecation warnings are wanted first tho. See also #96112.

Fixes #85063 and #89320.

__Further Development?__
- Fixed the mask dtype checking for the cuda dispatch for `masked_fill` in `aten/src/ATen/native/cuda/Indexing.cu`

Pull Request resolved: #96594
Approved by: https://github.com/malfet, https://github.com/ngimel
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
[BC] Allow only bool tensors as mask in masked_select (pytorch#96112
9e7e500 
)

`byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0)
Deprecation warning was added by pytorch#22261

Also, fix bunch of syntactic errors in comments

Pull Request resolved: pytorch#96112
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@gchanan gchanan gchanan approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

+1 more reviewer

@li-roy li-roy li-roy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Merged module: cuda Related to torch.cuda, and CUDA support in general module: docs Related to our documentation, both in docs/ and docblocks module: internals Related to internal abstractions in c10 and ATen module: typing Related to mypy type annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@izdeby @facebook-github-bot @ezyang @gchanan @li-roy @pytorchbot @mruberry