-
Notifications
You must be signed in to change notification settings - Fork 25k
frobenius_norm onnx export added #23536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bddppq please review |
looks good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will land once the review comment in test_onnx_opset.py is resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@bddppq this is updated and ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Phabricator tests are failing with onnx errors. |
@VitalyFedyunin @bddppq I don't have access. Where can I find more details? |
@VitalyFedyunin @bddppq Could you help with this? |
…oof/norm # Conflicts: # torch/onnx/symbolic_opset9.py
Looking |
It was a flaky test, landing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@bddppq Any updates on this PR? |
No description provided.