Skip to content

frobenius_norm onnx export added #23536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

neginraoof
Copy link
Contributor

No description provided.

@pytorchbot pytorchbot added the module: onnx Related to torch.onnx label Jul 30, 2019
@neginraoof
Copy link
Contributor Author

@bddppq please review

@neginraoof neginraoof mentioned this pull request Jul 30, 2019
@lara-hdr
Copy link
Contributor

looks good :)

Copy link
Contributor

@bddppq bddppq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will land once the review comment in test_onnx_opset.py is resolved

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Copy link
Contributor Author

@bddppq this is updated and ready

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@VitalyFedyunin
Copy link
Contributor

Phabricator tests are failing with onnx errors.

@neginraoof
Copy link
Contributor Author

@VitalyFedyunin @bddppq I don't have access. Where can I find more details?

@neginraoof
Copy link
Contributor Author

@VitalyFedyunin @bddppq Could you help with this?

@bddppq
Copy link
Contributor

bddppq commented Aug 3, 2019

Looking

@bddppq
Copy link
Contributor

bddppq commented Aug 3, 2019

It was a flaky test, landing

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Copy link
Contributor Author

@bddppq Any updates on this PR?

@facebook-github-bot
Copy link
Contributor

@bddppq merged this pull request in dfd8a08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants