Skip to content

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 6, 2019

Replaces and closes #23864.

When opening a pull request, GitHub shows you this:

image

Or this:

image

However, that links to https://github.com/pytorch/pytorch/blob/master/.github/CONTRIBUTING.md which looks like:

image

As the commit message shows, that was a placeholder. There's already a real CONTRIBUTING.md document, so delete the placeholder.

@pytorchbot pytorchbot added the module: infra Relates to CI infrastructure label Aug 6, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 52be144.

@hugovk hugovk deleted the patch-1 branch August 7, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: infra Relates to CI infrastructure open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants