Allow SyncBatchNorm without DDP in inference mode #24815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrshenli
reviewed
Aug 19, 2019
| process_group = torch.distributed.group.WORLD | ||
| if self.process_group: | ||
| process_group = self.process_group | ||
| world_size = torch.distributed.get_world_size(process_group) |
There was a problem hiding this comment.
process_group.size() should work as well.
There was a problem hiding this comment.
From the implementation of get_group_size it looks like .size() is not sufficient?
pytorch/torch/distributed/distributed_c10d.py
Lines 194 to 204 in dfdb86a
ppwwyyxx
force-pushed
the
export-D16883694
branch
from
f45d957 to
01c5124
Compare
ppwwyyxx
force-pushed
the
export-D16883694
branch
from
01c5124 to
dc2d7c2
Compare
There was a problem hiding this comment.
@ppwwyyxx is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fix pytorch#22538 Pull Request resolved: pytorch#24815 Test Plan: Can run a detectron2 evaluation without entering DDP. #sandcastle Differential Revision: D16883694 fbshipit-source-id: a9199a82a55ba784a9d80005969cccf32d6b4827
ppwwyyxx
force-pushed
the
export-D16883694
branch
from
dc2d7c2 to
e8a5a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix #22538
Differential Revision: D16883694