Skip to content

Fix for Conv shape check prints overflowed ints #25827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Fix for Conv shape check prints overflowed ints #25827

wants to merge 7 commits into from

Conversation

rajanksin
Copy link
Contributor

Fix for issue #19947

@rajanksin rajanksin changed the title Conv shape check prints overflowed ints #19947 Fix for Conv shape check prints overflowed ints Sep 8, 2019
@soumith
Copy link
Member

soumith commented Sep 8, 2019

thanks, i'm actually landing #25146 which is the same bugfix, but you have a test too :)
Once that's landed we can rebase this PR for the test

@rajanksin
Copy link
Contributor Author

@soumith Thanks for the heads up. I am fairly new to pytorch and this is my first stab @ pytorch issues. Any suggestions on the CI build failures?

@soumith
Copy link
Member

soumith commented Sep 8, 2019

@pytorchbot rebase this please

@soumith
Copy link
Member

soumith commented Sep 8, 2019

@spidydev the tests had some kind of infra failure. i've rebased the PR, let's see.

@rajanksin
Copy link
Contributor Author

@soumith @tczhangzhi is the pipeline still broken ? I am unable to pass CI ? Any suggestions?

@tczhangzhi
Copy link
Contributor

As far as I know, this error is not caused by us this time:

========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/6fb5d7bd-d9c2-4dc5-8da0-3b3af50308a6.sh
ios/TestApp/TestApp.xcodeproj/project.pbxproj
ios/TestApp/TestApp/Info.plist
The above files have tabs; please convert them to spaces
##[error]Bash exited with code '1'.
##[section]Finishing: CmdLine

Maybe @xta0 (who is working on pytorch/ios/TestApp/)could help.

@soumith
Copy link
Member

soumith commented Sep 20, 2019

@pytorchbot rebase this please

facebook-github-bot
facebook-github-bot reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@soumith merged this pull request in 916eee1.

mingbowan pushed a commit to mingbowan/pytorch that referenced this pull request Sep 23, 2019
@rajanksin
Fix for Conv shape check prints overflowed ints (pytorch#25827)
518d52a 
Summary:
Fix for issue pytorch#19947
Pull Request resolved: pytorch#25827

Differential Revision: D17508653

Pulled By: soumith

fbshipit-source-id: 1afec60b9b39de5f2d0be44a170650aa4c1879cf
@ssnl ssnl mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
Merged module: nn Related to torch.nn open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rajanksin @soumith @tczhangzhi @facebook-github-bot @ezyang @pytorchbot @mruberry