Ensure that DDP wrapped module has parameters that require gradients #25858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: distributed
pietern
changed the title
pietern
changed the title
pietern
reviewed
Sep 9, 2019
pietern
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Thanks, @danthe3rd, one more comment regarding the naming of the test.
Can you update, check if CI stays green, and then land?
|
@pytorchbot retest this please |
|
The failing tests seem unrelated to this change, as they fail with this error |
|
@pytorchbot rebase this please |
|
@danthe3rd Thanks -- I think this must be due to CI staleness. The CircleCI workspace gets clobbered after a while, so retesting no longer works on the same commit. |
|
So should I land it? |
|
@danthe3rd Yes, let's do it! :) |
There was a problem hiding this comment.
@danthe3rd is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@danthe3rd merged this pull request in 46539ee. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…ytorch#25858) Summary: …ent - see pytorch#25552 **TEST PLAN** ``` python test/run_test.py -f distributed ``` Pull Request resolved: pytorch#25858 Differential Revision: D17687542 Pulled By: danthe3rd fbshipit-source-id: 11bfe4142e72bb21382b30379fe10e60418c7ec9
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
…ytorch#25858) Summary: …ent - see pytorch#25552 **TEST PLAN** ``` python test/run_test.py -f distributed ``` Pull Request resolved: pytorch#25858 Differential Revision: D17687542 Pulled By: danthe3rd fbshipit-source-id: 11bfe4142e72bb21382b30379fe10e60418c7ec9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent - see #25552
TEST PLAN