Buffer python warning to avoid deadlocks #26613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorchbot
added
oncall: jit
albanD
changed the title
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Oct 1, 2019
ghstack-source-id: 51c0e66 Pull Request resolved: pytorch#26613
[ghstack-poisoned]
This was referenced Oct 1, 2019
albanD
changed the title
|
You need to rebase to master to fix build failures |
ezyang
reviewed
Oct 2, 2019
ezyang
reviewed
Oct 2, 2019
ezyang
reviewed
Oct 2, 2019
ezyang
reviewed
Oct 2, 2019
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Oct 2, 2019
ghstack-source-id: 33b5bc7 Pull Request resolved: pytorch#26613
Differential Revision: [D17692505](https://our.internmc.facebook.com/intern/diff/D17692505) [ghstack-poisoned]
ezyang
reviewed
Oct 2, 2019
ezyang
reviewed
Oct 2, 2019
ezyang
reviewed
Oct 2, 2019
|
Looks good. Just some C++ bits; I also wanna know what the locking strategy is. |
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Oct 2, 2019
ghstack-source-id: 9d1a3d6 Pull Request resolved: pytorch#26613
|
Don't forget to request re-review (click the little circle arrow icon next to the reviewer) when you want rereview |
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
ezyang
reviewed
Nov 1, 2019
docs/cpp/source/Doxyfile
Outdated
| @@ -70,6 +70,8 @@ RECURSIVE = YES | |||
| # Blacklist certain file patterns from the INPUT section. | |||
| EXCLUDE = ../../../torch/csrc/api/include/torch/nn/pimpl-inl.h \ | |||
| ../../../torch/csrc/api/include/torch/detail | |||
| # Increase the max node size for our large files | |||
| DOT_GRAPH_MAX_NODES = 100 | |||
There was a problem hiding this comment.
don't put this in an unrelated diff, this is what stacks are for!! Cross referencing with #29041
There was a problem hiding this comment.
This is actually related. the cpp docs does not build for Exception.h without this.
See build failures on the previous commit here: https://github.com/pytorch/pytorch/runs/284960182
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 4, 2019
ghstack-source-id: 2e5cc52 Pull Request resolved: pytorch#26613
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 6, 2019
ghstack-source-id: 29f87d8 Pull Request resolved: pytorch#26613
Differential Revision: [D18249633](https://our.internmc.facebook.com/intern/diff/D18249633) [ghstack-poisoned]
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
ghstack-source-id: ca36b34 Pull Request resolved: pytorch/pytorch#26613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18249633