Skip to content

fix type annotation #26930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Sep 26, 2019

Retrying to import #26531.

Stack from ghstack:

Differential Revision: D17614745

@pytorchbot pytorchbot added module: optimizer Related to torch.optim module: typing Related to mypy type annotations labels Sep 26, 2019
vincentqb added a commit that referenced this pull request Sep 26, 2019
ghstack-source-id: 1a79d5b
Pull Request resolved: #26930
@vincentqb vincentqb changed the title fix type annotation #26531 fix type annotation Sep 26, 2019
@vincentqb vincentqb requested a review from yf225 September 26, 2019 22:39
@vincentqb
Copy link
Contributor Author

@pytorchbot retest this please

@facebook-github-bot
Copy link
Contributor

@vincentqb merged this pull request in e4fba75.

@facebook-github-bot facebook-github-bot deleted the gh/vincentqb/27/head branch October 28, 2019 22:21
pdlive215 pushed a commit to pdlive215/pytorch that referenced this pull request Nov 27, 2019
Summary: Pull Request resolved: pytorch#26930

Test Plan: Imported from OSS

Differential Revision: D17614745

Pulled By: vincentqb

fbshipit-source-id: 1c29543f74d9cf307e9665aa890b4830b886fe63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: optimizer Related to torch.optim module: typing Related to mypy type annotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants