Fix race condition in Function::optimized_graph(). #27012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic is buggy, and will fail in the following situation: Thread A: check optimized_graph_, it is empty. Thread A: claim the mutex in order to initialize optimized_graph_. Thread A: copy graph_ into optimized_graph_. Thread A: start running optimizations on optimized_graph_. Thread B: check optimized_graph_, it is not empty. Thread B: start using optimized_graph_. BUG: Thread B is using the graph while it's still being mutated by Thread A. [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Sep 28, 2019
The current logic is buggy, and will fail in the following situation: Thread A: check optimized_graph_, it is empty. Thread A: claim the mutex in order to initialize optimized_graph_. Thread A: copy graph_ into optimized_graph_. Thread A: start running optimizations on optimized_graph_. Thread B: check optimized_graph_, it is not empty. Thread B: start using optimized_graph_. BUG: Thread B is using the graph while it's still being mutated by Thread A. ghstack-source-id: a8bb36e Pull Request resolved: #27012
wanchaol
approved these changes
Sep 28, 2019
|
@ZolotukhinM merged this pull request in 310ebb4. |
|
Pull Request for v1.3.0: #27323 |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#27012 The current logic is buggy, and will fail in the following situation: Thread A: check optimized_graph_, it is empty. Thread A: claim the mutex in order to initialize optimized_graph_. Thread A: copy graph_ into optimized_graph_. Thread A: start running optimizations on optimized_graph_. Thread B: check optimized_graph_, it is not empty. Thread B: start using optimized_graph_. BUG: Thread B is using the graph while it's still being mutated by Thread A. Test Plan: Imported from OSS Differential Revision: D17649149 Pulled By: ZolotukhinM fbshipit-source-id: ab82a4e76003b88733d219ecd47a42d38be2269c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The current logic is buggy, and will fail in the following situation:
Thread A: check optimized_graph_, it is empty.
Thread A: claim the mutex in order to initialize optimized_graph_.
Thread A: copy graph_ into optimized_graph_.
Thread A: start running optimizations on optimized_graph_.
Thread B: check optimized_graph_, it is not empty.
Thread B: start using optimized_graph_.
BUG: Thread B is using the graph while it's still being mutated by
Thread A.
Differential Revision: D17649149