C++ API: torch::nn::LogSoftmax #27462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbelevich
suggested changes
Oct 7, 2019
There was a problem hiding this comment.
Please change it to c10::optional<int64_t> with c10::nullopt default value
|
Thanks a lot for the great work! We will need some fixes as suggested in #27446. |
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Add torch::nn::LogSoftmax module and functional support for the C++ API. Related Issue: pytorch#25883 Reviewer: yf225 Pull Request resolved: pytorch#27462 Differential Revision: D17867121 Pulled By: yf225 fbshipit-source-id: dae8ac981c1c6ccdef013cd2d886ad4a043f6243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add torch::nn::LogSoftmax module and functional support for the C++ API.
Related Issue: #25883
Reviewer: @yf225