Fix padding_idx in the new embedding cuda kernel. #27731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
The current embedding backwards cuda kernel is somewhat broken. It effectively ignores padding_idx and also incorrectly drops an index from the input. This commit fixes that bug and fixes the unit test so that this behavior won't break in the future.
EthanSteinberg
force-pushed
the
fix_padding_idx
branch
from
d6576d5 to
5298a21
Compare
|
@bddppq Would it be possible for you to review this change or assign an appropriate reviewer? I think you were last person to review a change to the relevant CUDA kernel. |
ngimel
approved these changes
Oct 12, 2019
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 14, 2019
Summary: The current embedding backwards CUDA kernel is somewhat broken. It effectively ignores padding_idx and also incorrectly drops an index from the input. This commit fixes that bug and fixes the unit test so that this behavior won't break in the future. This fixes pytorch/pytorch#26302. Pull Request resolved: pytorch/pytorch#27731 Differential Revision: D17893803 Pulled By: ngimel fbshipit-source-id: 4ba02a17ec0e29a7016d65480d4ff0c276550616
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: The current embedding backwards CUDA kernel is somewhat broken. It effectively ignores padding_idx and also incorrectly drops an index from the input. This commit fixes that bug and fixes the unit test so that this behavior won't break in the future. This fixes pytorch#26302. Pull Request resolved: pytorch#27731 Differential Revision: D17893803 Pulled By: ngimel fbshipit-source-id: 4ba02a17ec0e29a7016d65480d4ff0c276550616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current embedding backwards CUDA kernel is somewhat broken. It effectively ignores padding_idx and also incorrectly drops an index from the input.
This commit fixes that bug and fixes the unit test so that this behavior won't break in the future.
This fixes #26302.