Skip to content

Fix Type Errors in Examples about Named Tensor #27828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Type Errors in Examples about Named Tensor #27828

wants to merge 1 commit into from

Conversation

standbyme
Copy link

names should be tuple

@standbyme standbyme changed the title Update named_tensor.rst Fix Type Errors in Examples about Named Tensor Oct 14, 2019
@zou3519
Copy link
Contributor

zou3519 commented Oct 14, 2019

This fixes #27848

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ssnl
Copy link
Collaborator

ssnl commented Oct 14, 2019

@zou3519 maybe worth submitting a patch to pytorch/***.io? :)

@zou3519
Copy link
Contributor

zou3519 commented Oct 14, 2019

The "right way" to update the website is to submit a patch to v1.3.0 and rebuild the documentation for that

@standbyme standbyme deleted the patch-1 branch October 15, 2019 00:23
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in a23edd6.

thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
`names` should be `tuple`
Pull Request resolved: pytorch#27828

Differential Revision: D17908112

Pulled By: zou3519

fbshipit-source-id: bd1454c5d6e6b690955f49380e34c4b0ddaf879b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants