Skip to content

Enabled torch.unique for bool tensors #28374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Enabled torch.unique for bool tensors #28374

wants to merge 4 commits into from

Conversation

izdeby
Copy link
Contributor

@izdeby izdeby commented Oct 21, 2019

Enabled torch.unique for bool tensors.
Tested via unit tests

issue

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izdeby has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@VitalyFedyunin
Copy link
Contributor

Still multiple flake8 issues

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izdeby has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izdeby has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@izdeby
Copy link
Contributor Author

izdeby commented Oct 22, 2019

@VitalyFedyunin, all green

@facebook-github-bot
Copy link
Contributor

@izdeby merged this pull request in 5e73e1f.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 22, 2019
Summary:
Enabled torch.unique for bool tensors.
Tested via unit tests

[issue](pytorch/pytorch#27691)
Pull Request resolved: pytorch/pytorch#28374

Differential Revision: D18043413

Pulled By: izdeby

fbshipit-source-id: 295ff03b9b61d33bbd2e05e6211c4f35a0ee23ea
@soumith soumith added this to the 1.3.1 milestone Oct 31, 2019
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
Enabled torch.unique for bool tensors.
Tested via unit tests

[issue](pytorch#27691)
Pull Request resolved: pytorch#28374

Differential Revision: D18043413

Pulled By: izdeby

fbshipit-source-id: 295ff03b9b61d33bbd2e05e6211c4f35a0ee23ea
@facebook-github-bot facebook-github-bot deleted the boolUnique branch July 13, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants