Skip to content

C++ API parity: PoissonNLLLoss #28755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

C++ API parity: PoissonNLLLoss #28755

wants to merge 11 commits into from

Conversation

pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Oct 27, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D18202436

@pbelevich pbelevich mentioned this pull request Oct 27, 2019
Closed
pbelevich added a commit that referenced this pull request Oct 27, 2019
@pbelevich
C++ API parity: PoissonNLLLoss
f187dca 
ghstack-source-id: c8d2b8f
Pull Request resolved: #28755
@yf225 yf225 mentioned this pull request Oct 27, 2019
Open
@pbelevich pbelevich mentioned this pull request Oct 28, 2019
Closed
yf225
yf225 reviewed Oct 29, 2019
View reviewed changes
@pbelevich
Update on "C++ API parity: PoissonNLLLoss"
51775af 
[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: PoissonNLLLoss"
4255650 
[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: PoissonNLLLoss"
20b2b5a 
[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: PoissonNLLLoss"
a707f13 
Differential Revision: [D18202436](https://our.internmc.facebook.com/intern/diff/D18202436)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: PoissonNLLLoss"
4ba4803 
Differential Revision: [D18202436](https://our.internmc.facebook.com/intern/diff/D18202436)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: PoissonNLLLoss"
707cb49 
Differential Revision: [D18202436](https://our.internmc.facebook.com/intern/diff/D18202436)

[ghstack-poisoned]
@pbelevich
Update on "C++ API parity: PoissonNLLLoss"
516dfe5 
Differential Revision: [D18202436](https://our.internmc.facebook.com/intern/diff/D18202436)

[ghstack-poisoned]
@pbelevich pbelevich mentioned this pull request Oct 30, 2019
Closed
@pbelevich pbelevich requested a review from yf225 October 30, 2019 22:54
pbelevich
pbelevich commented Oct 30, 2019
View reviewed changes
yf225
yf225 reviewed Oct 31, 2019
View reviewed changes
@pbelevich pbelevich mentioned this pull request Oct 31, 2019
Closed
@pbelevich pbelevich requested a review from yf225 November 1, 2019 00:25
yf225
yf225 approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich Thanks so much for the awesome work!

@facebook-github-bot
Copy link
Contributor

@pbelevich merged this pull request in 4a94eaa.

@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/48/head branch November 5, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yf225 yf225 yf225 approved these changes

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbelevich @facebook-github-bot @yf225 @mruberry