argmax for half datatype fix #28787
Closed
argmax for half datatype fix #28787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
ssnl
reviewed
Oct 28, 2019
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
ngimel
reviewed
Oct 28, 2019
ngimel
approved these changes
Oct 28, 2019
[ghstack-poisoned]
gchanan
reviewed
Oct 28, 2019
gchanan
approved these changes
Oct 28, 2019
Differential Revision: [D18175646](https://our.internmc.facebook.com/intern/diff/D18175646) [ghstack-poisoned]
Differential Revision: [D18175646](https://our.internmc.facebook.com/intern/diff/D18175646) [ghstack-poisoned]
Differential Revision: [D18194420](https://our.internmc.facebook.com/intern/diff/D18194420) [ghstack-poisoned]
|
@pbelevich merged this pull request in 7e8c48b. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 29, 2019
Summary: Pull Request resolved: pytorch/pytorch#28787 Stack from [ghstack](https://github.com/ezyang/ghstack): * **#28787 argmax for half datatype fix** Test Plan: Imported from OSS Differential Revision: D18194420 Pulled By: pbelevich fbshipit-source-id: d2abec1ea8a9ce3a93aec5a2c5bba57d163197e6
pbelevich
added a commit
to pbelevich/pytorch
that referenced
this pull request
Oct 30, 2019
Summary: Pull Request resolved: pytorch#28787 Stack from [ghstack](https://github.com/ezyang/ghstack): * **pytorch#28787 argmax for half datatype fix** Test Plan: Imported from OSS Differential Revision: D18194420 Pulled By: pbelevich fbshipit-source-id: d2abec1ea8a9ce3a93aec5a2c5bba57d163197e6
soumith
pushed a commit
that referenced
this pull request
Nov 1, 2019
Summary: Pull Request resolved: #28787 Stack from [ghstack](https://github.com/ezyang/ghstack): * **#28787 argmax for half datatype fix** Test Plan: Imported from OSS Differential Revision: D18194420 Pulled By: pbelevich fbshipit-source-id: d2abec1ea8a9ce3a93aec5a2c5bba57d163197e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18194420
Fixing #28623