-
Notifications
You must be signed in to change notification settings - Fork 25k
Design doc for distributed autograd. #29175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
pritamdamania87
wants to merge
3
commits into
gh/pritamdamania87/23/base
from
gh/pritamdamania87/23/head
Closed
Design doc for distributed autograd. #29175
pritamdamania87
wants to merge
3
commits into
gh/pritamdamania87/23/base
from
gh/pritamdamania87/23/head
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates our docs to include a design doc for distributed autograd. Currently, this doc only covers the FAST mode algorithm. The Smart mode algorithm section just refers to the original RFC. There is a section for Distributed Optimizer that we can complete once we've finalized the API for the same. Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 5, 2019
Updates our docs to include a design doc for distributed autograd. Currently, this doc only covers the FAST mode algorithm. The Smart mode algorithm section just refers to the original RFC. There is a section for Distributed Optimizer that we can complete once we've finalized the API for the same. Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/) ghstack-source-id: 93254358 Pull Request resolved: #29175
mrshenli
reviewed
Nov 5, 2019
Updates our docs to include a design doc for distributed autograd. Currently, this doc only covers the FAST mode algorithm. The Smart mode algorithm section just refers to the original RFC. There is a section for Distributed Optimizer that we can complete once we've finalized the API for the same. Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 8, 2019
Pull Request resolved: #29175 Updates our docs to include a design doc for distributed autograd. Currently, this doc only covers the FAST mode algorithm. The Smart mode algorithm section just refers to the original RFC. There is a section for Distributed Optimizer that we can complete once we've finalized the API for the same. ghstack-source-id: 93560691 Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)
zzzwen
reviewed
Nov 9, 2019
mrshenli
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contents LGTM! Thanks! Please get a stamp from @jlin27 as well.
jlin27
reviewed
Nov 11, 2019
Updates our docs to include a design doc for distributed autograd. Currently, this doc only covers the FAST mode algorithm. The Smart mode algorithm section just refers to the original RFC. There is a section for Distributed Optimizer that we can complete once we've finalized the API for the same. Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 12, 2019
Pull Request resolved: #29175 Updates our docs to include a design doc for distributed autograd. Currently, this doc only covers the FAST mode algorithm. The Smart mode algorithm section just refers to the original RFC. There is a section for Distributed Optimizer that we can complete once we've finalized the API for the same. ghstack-source-id: 93701129 Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)
jlin27
approved these changes
Nov 12, 2019
This pull request has been merged in c3b2c2e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.
There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.
Differential Revision: D18318949