Skip to content

Conversation

jamesr66a
Copy link
Collaborator

@jamesr66a jamesr66a commented Nov 14, 2019

Stack from ghstack:

These nodes were erroneously being put at the end of the graph, outside the proper TracedModuleForward Calls

cc @ilia-cher

Differential Revision: D18499142

@jamesr66a jamesr66a requested a review from apaszke as a code owner November 14, 2019 03:50
jamesr66a pushed a commit that referenced this pull request Nov 14, 2019
ghstack-source-id: fa15a18
Pull Request resolved: #29791
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 14, 2019
@jamesr66a jamesr66a requested review from zdevito and suo November 14, 2019 03:54
@facebook-github-bot
Copy link
Contributor

@jamesr66a merged this pull request in 90ac35b.

csarofeen pushed a commit to mruberry/pytorch that referenced this pull request Nov 18, 2019
Summary: Pull Request resolved: pytorch#29791

Test Plan: Imported from OSS

Differential Revision: D18499142

Pulled By: jamesr66a

fbshipit-source-id: 6c2864dfbfa0419c8c888d55e082a619d058b3ee
@facebook-github-bot facebook-github-bot deleted the gh/jamesr66a/146/head branch November 18, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants