Add RPC internal helper that overrides the default pickler. #30185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable share_memory over RPC, add an internal helper that overrides the default RPC pickler. Replace D18598974 Differential Revision: [D18621372](https://our.internmc.facebook.com/intern/diff/D18621372/) [ghstack-poisoned]
zzzwen
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
zzzwen
pushed a commit
that referenced
this pull request
Nov 20, 2019
To enable share_memory over RPC, add an internal helper that overrides the default RPC pickler. Replace D18598974 Differential Revision: [D18621372](https://our.internmc.facebook.com/intern/diff/D18621372/) ghstack-source-id: 94299660 Pull Request resolved: #30185
|
Replaced #30173 |
pritamdamania87
approved these changes
Nov 20, 2019
| @@ -14,6 +14,7 @@ | |||
| from common_utils import load_tests | |||
| import dist_utils | |||
| from dist_utils import dist_init | |||
| from torch.distributed.rpc.api import _use_rpc_pickler | |||
There was a problem hiding this comment.
nit: can we put this in torch.distributed.rpc and not torch.distributed.rpc.api?
|
@pritamdamania87 Thanks for clarifying, makes sense. Can you file an issue so we don't lose track of removing this eventually? Retaining this is a liability in my opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
To enable share_memory over RPC, add an internal helper that overrides the default RPC pickler.
Replace D18598974
Differential Revision: D18621372