Fix error checking of CUDA multi_margin_loss. #30825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It didn't verify in the 1-d case that the targets were size 1.. [ghstack-poisoned]
This was referenced Dec 5, 2019
Closed
albanD
approved these changes
Dec 5, 2019
|
Does that leak memory on error as well? |
|
looks like it, but the test doesn't catch it because all the combinations are valid (unlike MultiLabelMargin where they aren't, so they trigger the errors). |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30825 It didn't verify in the 1-d case that the targets were size 1.. Test Plan: Imported from OSS Differential Revision: D18833659 Pulled By: gchanan fbshipit-source-id: 9b0276e7b0423fdaf2ba7cfa34bde541558c61f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It didn't verify in the 1-d case that the targets were size 1..
Differential Revision: D18833659