check devices for all input tensors in index_put #31280
Conversation
aten/src/ATen/native/Indexing.cpp
Outdated
| @@ -251,6 +251,10 @@ Tensor & _index_put_impl_(Tensor & self, TensorList indices, const Tensor & valu | |||
| AT_INDEX_ERROR("too many indices for tensor of dimension ", self.dim(), " (got ", indices.size(), ")"); | |||
| } | |||
| if (accumulate && self.device().type() == kCUDA) { | |||
| if (value.device() != self.device()) { | |||
| AT_ERROR("expected device ", self.device(), " but got device ", | |||
There was a problem hiding this comment.
Isn't AT_ERROR deprecated in favor of TORCH_CHECK(false, ...)?
There was a problem hiding this comment.
You are right. There are 336 instances of AT_ERROR in ATen though.
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
CircleCI build failures summaryAs of commit 0e8dc12:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 2 upstream failures recognized by patterns:These builds matched patterns, but were probably caused by upstream breakages: This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ngimel is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fix for pytorch#30960 Pull Request resolved: pytorch#31280 Differential Revision: D19149114 Pulled By: ngimel fbshipit-source-id: af185a98ac6ea614f43bbf865de02ea113d4ed56
Fix for #30960