Optimize zero length input #31602
Closed
Optimize zero length input #31602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D19192467 |
💊 CircleCI build failures summary and remediationsAs of commit a6cfae1: Commit a6cfae1 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
Summary: Pull Request resolved: pytorch/glow#3943 Zero length input is something we hit fairly frequently in practice. Previous handling of global TensorPool involves two locks per input (acquire and reclaim). Here we use a specialized anchor tensor to host zero length input. Note that it is only padded to max sequence length. If necessary, an easy extension can be added to pad to max `InputPlaceholder.getType().size()`. Reviewed By: jfix71 Differential Revision: D19192467 fbshipit-source-id: bfa7da6bf72f9013001dc7157527fc56c070f913
yinghai
force-pushed
the
export-D19192467
branch
from
37f81aa to
a6cfae1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19192467 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 27, 2019
Summary: Pull Request resolved: #31602 Pull Request resolved: pytorch/glow#3943 Zero length input is something we hit fairly frequently in practice. Previous handling of global TensorPool involves two locks per input (acquire and reclaim). Here we use a specialized anchor tensor to host zero length input. Note that it is only padded to max sequence length. If necessary, an easy extension can be added to pad to max `InputPlaceholder.getType().size()`. Reviewed By: jfix71 Differential Revision: D19192467 fbshipit-source-id: cafdc1eb7bf9b9d6ead04a0243b0be838f6b71cd
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#31602 Pull Request resolved: pytorch/glow#3943 Zero length input is something we hit fairly frequently in practice. Previous handling of global TensorPool involves two locks per input (acquire and reclaim). Here we use a specialized anchor tensor to host zero length input. Note that it is only padded to max sequence length. If necessary, an easy extension can be added to pad to max `InputPlaceholder.getType().size()`. Reviewed By: jfix71 Differential Revision: D19192467 fbshipit-source-id: cafdc1eb7bf9b9d6ead04a0243b0be838f6b71cd
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
Summary: Pull Request resolved: pytorch/pytorch#31602 Pull Request resolved: pytorch#3943 Zero length input is something we hit fairly frequently in practice. Previous handling of global TensorPool involves two locks per input (acquire and reclaim). Here we use a specialized anchor tensor to host zero length input. Note that it is only padded to max sequence length. If necessary, an easy extension can be added to pad to max `InputPlaceholder.getType().size()`. Reviewed By: jfix71 Differential Revision: D19192467 fbshipit-source-id: cafdc1eb7bf9b9d6ead04a0243b0be838f6b71cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Zero length input is something we hit fairly frequently in practice. Previous handling of global TensorPool involves two locks per input (acquire and reclaim). Here we use a specialized anchor tensor to host zero length input. Note that it is only padded to max sequence length. If necessary, an easy extension can be added to pad to max
InputPlaceholder.getType().size().Differential Revision: D19192467