Added support for Dim operation in ONNX export #31928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
lara-hdr
reviewed
Jan 8, 2020
💊 CircleCI build failures summary and remediationsAs of commit bce520a: Commit bce520a was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 6 times. |
BowenBao
requested changes
Jan 8, 2020
zou3519
added
the
triaged
added 4 commits
January 10, 2020 10:27
While ONNX does not currently directly support the Dim operation on a tensor, we can provide the same functionality with two ONNX operations. This allows us to support Dim for all opsets. It may be adventageous to add support for Dim into a future ONNX opset, and use that for more efficient code. While testing dim op found that there is an issue with empty blocks withing if statements. Modified graph generation to prevent generation of empty if blocks.
|
@houseroad can you please take a look at this it should be ready for review now. Thanks |
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
approved these changes
Jan 13, 2020
| for (Block* block : node->blocks()) { | ||
| FixupONNXIfs(block); | ||
| if (block->nodes().begin() == block->nodes().end()) { | ||
| //ONNX does not support empty blocks, must use some op which does nothing |
| using namespace ::c10::onnx; | ||
| } | ||
|
|
||
| void FixupONNXIfs(Block* block) { |
There was a problem hiding this comment.
Add comment, why we need this pass?
houseroad
reviewed
Jan 13, 2020
| if (node->kind() == ::c10::onnx::If) { | ||
| auto* if_node = node; | ||
| auto* graph = if_node->owningGraph(); | ||
| for (Block* block : node->blocks()) { |
There was a problem hiding this comment.
Nit: block is shadowed by inner variable.
houseroad
reviewed
Jan 13, 2020
| } | ||
| } | ||
| else { | ||
| for (Block* block : node->blocks()) { |
There was a problem hiding this comment.
Nit: block is shadowed by inner variable.
|
Feel free to create another PR to address nits :-) |
|
@houseroad merged this pull request in a472f02. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: While ONNX does not currently directly support the Dim operation on a tensor, we can provide the same functionality with two ONNX operations. This allows us to support Dim for all opsets. It may be adventageous to add support for Dim into a future ONNX opset, and use that for more efficient code. While testing dim op found that there is an issue with empty blocks withing if statements. Modified graph generation to prevent generation of empty if blocks. Fixes pytorch#27569 Pull Request resolved: pytorch#31928 Reviewed By: hl475 Differential Revision: D19376602 Pulled By: houseroad fbshipit-source-id: 111682b058a5341f5cca6c1a950c83ae412a4c6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While ONNX does not currently directly support the Dim operation on a
tensor, we can provide the same functionality with two ONNX operations.
This allows us to support Dim for all opsets. It may be adventageous to
add support for Dim into a future ONNX opset, and use that for more
efficient code.
While testing dim op found that there is an issue with empty blocks
withing if statements. Modified graph generation to prevent generation
of empty if blocks.
Fixes #27569