[jit] Enable copy.deepcopy and copy.copy for RecursiveScriptModule

[jerryzh168]

Stack from ghstack:

• [jit] Remove unnecessary clone APIs for script::Module and RecursiveScriptModule #40297 [jit] Remove unnecessary clone APIs for script::Module and RecursiveScriptModule
• [jit] Enable copy.deepcopy and copy.copy for RecursiveScriptModule #32685 [jit] Enable copy.deepcopy and copy.copy for RecursiveScriptModule

Summary:

Test Plan:
.

Reviewers:
.
Subscribers:

Tasks:

Tags:

Differential Revision: D21220755

[kostmo]

💊 CI failures summary and remediations

As of commit 80b0641 (more details on the Dr. CI page):

---

💚 💚 Looks good so far! There are no failures yet. 💚 💚

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 176 times.

[suo]

Can you mark this PR as BC-breaking

[jerryzh168]

Got this:

Jun 19 23:07:12 ERROR [0.004s]: test_model_save_error (test_jit.TestJit) 
Jun 19 23:07:12 ---------------------------------------------------------------------- 
Jun 19 23:07:12 Traceback (most recent call last): 
Jun 19 23:07:12   File "/var/lib/jenkins/workspace/test/test_jit.py", line 355, in test_model_save_error 
Jun 19 23:07:12     torch.save(FooToPickle(), fname) 
Jun 19 23:07:12   File "/opt/conda/lib/python3.6/site-packages/torch/serialization.py", line 364, in save 
Jun 19 23:07:12     _save(obj, opened_file, pickle_module, pickle_protocol) 
Jun 19 23:07:12   File "/opt/conda/lib/python3.6/site-packages/torch/serialization.py", line 468, in _save 
Jun 19 23:07:12     pickler.dump(obj) 
Jun 19 23:07:12 RuntimeError: Tried to serialize object __torch__.torch.jit.ScriptModule which does not have a __getstate__ method defined! 
Jun 19 23:07:12  

I think it's because I removed __getstate__ from RecursiveScriptModule, can we remove this test now since we do have __getstate__ defined in script::Object and script::Module now? cc @zdevito, @jamesr66a

[zdevito]

That test is checking that there is an error with a reasonable error message for saving a module with TorchScript submodules. It looks like this change broke the friendly error message and made it something less understandable.

[jerryzh168]

That test is checking that there is an error with a reasonable error message for saving a module with TorchScript submodules. It looks like this change broke the friendly error message and made it something less understandable.

Fixed.

code changed

[zdevito]

Looks good

[facebook-github-bot]

This pull request has been merged in f652abc.