Fix torch::allclose to handle std::numeric_limits<T>::lowest() for integral types #32978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegral types [ghstack-poisoned]
pbelevich
requested review from
ebetica,
goldsborough and
yf225
as code owners
pbelevich
requested review from
VitalyFedyunin and
yf225
and removed request for
yf225,
ebetica and
goldsborough
VitalyFedyunin
approved these changes
Feb 4, 2020
yf225
reviewed
Feb 4, 2020
…st() for integral types" Fixes #32946 [ghstack-poisoned]
yf225
reviewed
Feb 4, 2020
…st() for integral types" Fixes #32946 Differential Revision: [D19726013](https://our.internmc.facebook.com/intern/diff/D19726013) [ghstack-poisoned]
yf225
approved these changes
Feb 4, 2020
…st() for integral types" Fixes #32946 Differential Revision: [D19726013](https://our.internmc.facebook.com/intern/diff/D19726013) [ghstack-poisoned]
…st() for integral types" Fixes #32946 Differential Revision: [D19726013](https://our.internmc.facebook.com/intern/diff/D19726013) [ghstack-poisoned]
…st() for integral types" Fixes #32946 Differential Revision: [D19726013](https://our.internmc.facebook.com/intern/diff/D19726013) [ghstack-poisoned]
|
@pbelevich merged this pull request in d141465. |
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
…tegral types (pytorch#32978) Summary: Pull Request resolved: pytorch#32978 Fixes pytorch#32946 Test Plan: Imported from OSS Differential Revision: D19726013 Pulled By: pbelevich fbshipit-source-id: ada4aeabc8e39016d24f1a40f02fb7c56f069cd3
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
…tegral types (pytorch#32978) Summary: Pull Request resolved: pytorch#32978 Fixes pytorch#32946 Test Plan: Imported from OSS Differential Revision: D19726013 Pulled By: pbelevich fbshipit-source-id: ada4aeabc8e39016d24f1a40f02fb7c56f069cd3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #32946
Differential Revision: D19726013