Check for consistent devices in at::where #33432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: - Add a check to ensure that all inputs to `where` lie on the same device Test Plan: - Added test_where_invalid_device
💊 CircleCI build failures summary and remediationsAs of commit 1bc6889: Commit 1bc6889 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
yf225
added
module: operators
triaged
VitalyFedyunin
approved these changes
Feb 19, 2020
|
Please fix lints before merge |
…where-device-mismatch
|
@VitalyFedyunin I think the lint error is due to some dependency installation issue. |
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Right, sorry. |
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
|
@VitalyFedyunin merged this pull request in 1a25747. |
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Changelog: - Add a check to ensure that all inputs to `where` lie on the same device Pull Request resolved: pytorch#33432 Test Plan: - Added test_where_invalid_device Fixes pytorch#33422 Differential Revision: D19981115 Pulled By: VitalyFedyunin fbshipit-source-id: 745896927edb53f61f3dd48ba9e1e6cd10d35434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
wherelie on the same deviceTest Plan:
Fixes #33422