-
Notifications
You must be signed in to change notification settings - Fork 25k
[pytorch][size] remove unused SparseCPUType from mobile build #33517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think any mobile model uses SparseCPU backend yet so we can skip generating dispatch code for this backend type. This will help reduce mobile code size with dynamic dispatch turned on, roughly ~100K for uncompressed iOS: D19616007 +413K v.s. D19616016 +319K. It probably doesn't affect much static dispatch build size as the unused static dispatch methods will be stripped by linker in the end. Differential Revision: [D19978633](https://our.internmc.facebook.com/intern/diff/D19978633/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D19978633/)! [ghstack-poisoned]
💊 CircleCI build failures summary and remediationsAs of commit 7408719:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🕵️ 1 new failure recognized by patternsThe following build failures do not appear to be due to upstream breakage:
|
…ild" I don't think any mobile model uses SparseCPU backend yet so we can skip generating dispatch code for this backend type. This will help reduce mobile code size with dynamic dispatch turned on, roughly ~100K for uncompressed iOS: D19616007 +413K v.s. D19616016 +319K. It probably doesn't affect much static dispatch build size as the unused static dispatch methods will be stripped by linker in the end. Differential Revision: [D19978633](https://our.internmc.facebook.com/intern/diff/D19978633/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D19978633/)! [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Feb 19, 2020
Pull Request resolved: #33517 I don't think any mobile model uses SparseCPU backend yet so we can skip generating dispatch code for this backend type. This will help reduce mobile code size with dynamic dispatch turned on, roughly ~100K for uncompressed iOS: D19616007 +413K v.s. D19616016 +319K. It probably doesn't affect much static dispatch build size as the unused static dispatch methods will be stripped by linker in the end. ghstack-source-id: 98578917 Differential Revision: [D19978633](https://our.internmc.facebook.com/intern/diff/D19978633/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D19978633/)!
ezyang
approved these changes
Feb 20, 2020
…ild" I don't think any mobile model uses SparseCPU backend yet so we can skip generating dispatch code for this backend type. This will help reduce mobile code size with dynamic dispatch turned on, roughly ~100K for uncompressed iOS: D19616007 +413K v.s. D19616016 +319K. It probably doesn't affect much static dispatch build size as the unused static dispatch methods will be stripped by linker in the end. Differential Revision: [D19978633](https://our.internmc.facebook.com/intern/diff/D19978633/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D19978633/)! [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Feb 20, 2020
Pull Request resolved: #33517 I don't think any mobile model uses SparseCPU backend yet so we can skip generating dispatch code for this backend type. This will help reduce mobile code size with dynamic dispatch turned on, roughly ~100K for uncompressed iOS: D19616007 +413K v.s. D19616016 +319K. It probably doesn't affect much static dispatch build size as the unused static dispatch methods will be stripped by linker in the end. ghstack-source-id: 98615810 Differential Revision: [D19978633](https://our.internmc.facebook.com/intern/diff/D19978633/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D19978633/)!
This pull request has been merged in 009293e. |
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
…h#33517) Summary: Pull Request resolved: pytorch#33517 I don't think any mobile model uses SparseCPU backend yet so we can skip generating dispatch code for this backend type. This will help reduce mobile code size with dynamic dispatch turned on, roughly ~100K for uncompressed iOS: D19616007 +413K v.s. D19616016 +319K. It probably doesn't affect much static dispatch build size as the unused static dispatch methods will be stripped by linker in the end. ghstack-source-id: 98615810 Test Plan: - CI & BuildSizeBot Reviewed By: linbinyu Differential Revision: D19978633 fbshipit-source-id: 27bf6ada2ba98482084cf23724cf400b538b0a03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I don't think any mobile model uses SparseCPU backend yet so we can skip
generating dispatch code for this backend type.
This will help reduce mobile code size with dynamic dispatch turned on,
roughly ~100K for uncompressed iOS: D19616007 +413K v.s. D19616016 +319K.
It probably doesn't affect much static dispatch build size as the unused
static dispatch methods will be stripped by linker in the end.
Differential Revision: D19978633
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!