Skip to content

[C++ API] Fix ModuleList compile error: error: 'begin' was not declared in this scope #34463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Mar 8, 2020

One example in the current docs for torch::nn::ModuleList doesn't compile, and this PR fixes it.
Fixes #32414.

@dr-ci
Copy link

dr-ci bot commented Mar 8, 2020

💊 CircleCI build failures summary and remediations

As of commit 75a5d44 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base 7d9f611 since Mar 07

    Please rebase on the viable/strict branch (expand for instructions)

    Since your merge base is older than viable/strict, run these commands:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 upstream failure recognized by patterns:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225 yf225 added the module: cpp Related to C++ API label Mar 9, 2020
@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in 739d460.

@facebook-github-bot facebook-github-bot deleted the fix_32414 branch July 13, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: cpp Related to C++ API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleList compile error: error: 'begin' was not declared in this scope
4 participants