Skip to content

Minor fix to quantized conv docstring #35134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

z-a-f
Copy link

@z-a-f z-a-f commented Mar 20, 2020

Stack from ghstack:

Differential Revision: D20571996

@z-a-f z-a-f requested a review from apaszke as a code owner March 20, 2020 23:27
@z-a-f z-a-f mentioned this pull request Mar 20, 2020
z-a-f pushed a commit that referenced this pull request Mar 20, 2020
ghstack-source-id: 4b4493d
Pull Request resolved: #35134
@z-a-f z-a-f requested review from jerryzh168 and dskhudia March 20, 2020 23:34
@dr-ci
Copy link

dr-ci bot commented Mar 21, 2020

💊 CircleCI build failures summary and remediations

As of commit 1c2f4d4 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/2 tentatively recognized as flaky ❄️

  • 1/2 broken upstream at merge base 8b8af0d from Mar 23 until Mar 24 (47 commits; 77ccb5c - 3f896ef)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


❄️ 1 tentatively flaky failure

1 failure tentatively classified as flaky but have not triggered reruns to confirm:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (1/1)

Step: "Test" (full log | pattern match details) ❄️

Mar 24 23:10:37 AssertionError: 11 not less than or equal to 1e-05 :
Mar 24 23:10:37 ---------------------------------------------------------------------- 
Mar 24 23:10:37 Traceback (most recent call last): 
Mar 24 23:10:37   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 24 23:10:37     self._join_processes(fn) 
Mar 24 23:10:37   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 24 23:10:37     self._check_return_codes(elapsed_time) 
Mar 24 23:10:37   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 24 23:10:37     self.assertEqual(first_process.exitcode, 0) 
Mar 24 23:10:37   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 24 23:10:37     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 24 23:10:37 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 24 23:10:37  
Mar 24 23:10:37 ---------------------------------------------------------------------- 
Mar 24 23:10:37 Ran 29 tests in 23.182s 
Mar 24 23:10:37  
Mar 24 23:10:37 FAILED (failures=1) 
Mar 24 23:10:37  
Mar 24 23:10:37 Generating XML reports... 
Mar 24 23:10:37 Generated XML report: test-reports/dist-gloo/TEST-JitRpcTestWithSpawn-20200324231014.xml 
Mar 24 23:10:37 Traceback (most recent call last): 
Mar 24 23:10:37   File "test/run_test.py", line 682, in <module> 

1 job timed out:

  • pytorch_macos_10_13_py3_test

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 5 times.

z-a-f pushed a commit that referenced this pull request Mar 24, 2020
ghstack-source-id: 3bb9b94
Pull Request resolved: #35134
@facebook-github-bot
Copy link
Contributor

@z-a-f merged this pull request in 6c39e36.

@facebook-github-bot facebook-github-bot deleted the gh/z-a-f/2/head branch March 28, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants